remove redundant translation cache clearing from TranslationController#67
Merged
remove redundant translation cache clearing from TranslationController#67
Conversation
Contributor
Author
|
Background: I had a painfull day of debugging zombie keys within a project with enabled Redis caching. With Redis, writing a cache entry requires two separate operations: These are not atomic. If a second cache invalidation fires between these two operations, the tag registration is lost while the cache entry survives - a "zombie key" that can never be cleared by tag-based invalidation. Removing the redundant And as a final note: Whether this fully resolves the zombie key problem requires further observation in production. |
benwalch
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove redundant
Translation::clearDependentCache()calls fromTranslationController(
save()already callsclearDependentCache()internally)exportAction()(export does not modify data, no cache invalidation needed)