Skip to content

fix: race condition between status check and provider lookup #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NeaguGeorgiana23 wants to merge 9 commits into
base: main
Choose a base branch
from
+10 −3
Open

fix: race condition between status check and provider lookup #108

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
212e050
fix race condition between status check and provider lookup
NeaguGeorgiana23 Jun 23, 2026
c327b5c
addressed CodeRabbit review
NeaguGeorgiana23 Jun 23, 2026
2be23ba
apply gemini suggestions
NeaguGeorgiana23 Jun 24, 2026
18f55be
apply gemini suggestions
NeaguGeorgiana23 Jun 24, 2026
0861ae9
Merge branch 'race_condttion' of https://github.com/open-feature/cpp-…
NeaguGeorgiana23 Jun 24, 2026
9b17006
Merge branch 'race_condttion' of https://github.com/open-feature/cpp-…
NeaguGeorgiana23 Jun 24, 2026
6a3bb4d
Merge branch 'race_condttion' of https://github.com/open-feature/cpp-…
NeaguGeorgiana23 Jun 24, 2026
1ed56b5
Merge branch 'race_condttion' of https://github.com/open-feature/cpp-…
NeaguGeorgiana23 Jun 24, 2026
8d1e0da
Merge branch 'race_condttion' of https://github.com/open-feature/cpp-…
NeaguGeorgiana23 Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions openfeature/client_api.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,15 @@ template <typename ResolutionDetailsType, typename ValueType,
std::unique_ptr<ResolutionDetailsType> ClientAPI::EvaluateFlag(
ValueType default_value, const std::optional<EvaluationContext>& ctx,
ProviderCallable provider_call) {
ProviderStatus status = GetProviderStatus();
std::shared_ptr<FeatureProviderStatusManager> manager =
provider_repository_.GetFeatureProviderStatusManager(domain_);
if (!manager) {
return std::make_unique<ResolutionDetailsType>(
default_value, Reason::kError, std::nullopt, FlagMetadata(),
ErrorCode::kGeneral, "Provider status manager not found for domain");
}

ProviderStatus status = manager->GetStatus();
Comment thread
NeaguGeorgiana23 marked this conversation as resolved.
if (status == ProviderStatus::kNotReady) {
return std::make_unique<ResolutionDetailsType>(
default_value, Reason::kError, std::nullopt, FlagMetadata(),
Expand All @@ -125,8 +133,7 @@ std::unique_ptr<ResolutionDetailsType> ClientAPI::EvaluateFlag(
ErrorCode::kProviderFatal, "Provider is in fatal error state");
}

std::shared_ptr<FeatureProvider> provider =
provider_repository_.GetProvider(domain_);
std::shared_ptr<FeatureProvider> provider = manager->GetProvider();
if (!provider) {
return std::make_unique<ResolutionDetailsType>(
default_value, Reason::kError, std::nullopt, FlagMetadata(),
Expand Down