Skip to content

Add Provider Repository#42

Merged
NeaguGeorgiana23 merged 7 commits into
mainfrom
provider_repository
Jan 5, 2026
Merged

Add Provider Repository#42
NeaguGeorgiana23 merged 7 commits into
mainfrom
provider_repository

Conversation

@NeaguGeorgiana23

Copy link
Copy Markdown
Contributor

This PR

Adds the Provider Repository and unit-tests for it.

Related Issues

Fixes #31

Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
@NeaguGeorgiana23 NeaguGeorgiana23 requested review from a team as code owners December 10, 2025 15:42
@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello @NeaguGeorgiana23, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces the ProviderRepository component, a core addition to the OpenFeature SDK. Its primary purpose is to centralize and streamline the management of feature providers, allowing for dynamic registration, retrieval, and lifecycle control of both default and domain-specific providers. This enhancement significantly improves the flexibility and robustness of how feature flags are integrated and managed within applications.

Highlights

  • New Provider Repository: Introduced a new ProviderRepository class responsible for managing FeatureProvider instances, including a default provider and domain-specific providers.
  • Provider Lifecycle Management: The repository handles the initialization and shutdown of feature providers, supporting both synchronous and asynchronous initialization based on configuration.
  • Status Management: It integrates with FeatureProviderStatusManager to track the status of each provider (e.g., ready, error, not ready) and ensures proper shutdown of old providers when new ones are set.
  • Comprehensive Unit Tests: Extensive unit tests have been added to validate the functionality of the ProviderRepository, covering various scenarios like default initialization, named providers, null provider handling, and shutdown behavior.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a ProviderRepository for managing feature providers, along with corresponding unit tests. The implementation is comprehensive, but there are a few critical issues to address. A potential null pointer dereference could crash the application, and the use of detached threads for asynchronous initialization can lead to use-after-free vulnerabilities and data races. I've also included a suggestion to improve future performance and maintainability by changing how EvaluationContext is passed. The unit tests are well-written and cover many scenarios, but they don't expose the race conditions or lifetime issues.

Comment thread openfeature/provider_repository.cpp Outdated
Comment thread openfeature/provider_repository.cpp Outdated
Comment thread openfeature/provider_repository.h Outdated
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Comment thread openfeature/provider_repository.h
Comment thread openfeature/provider_repository.cpp Outdated
Comment thread openfeature/provider_repository.cpp
Comment thread openfeature/provider_repository.cpp
Comment thread openfeature/provider_repository.cpp Outdated
Comment thread test/provider_repository_test.cpp Outdated
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>

@oxddr oxddr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As usual, please wait for @alichka06 approval.

Comment thread openfeature/provider_repository.cpp Outdated
Comment thread openfeature/provider_repository.cpp Outdated
Comment thread openfeature/provider_repository.cpp Outdated
Comment thread openfeature/provider_repository.cpp Outdated
Comment thread test/provider_repository_test.cpp Outdated
Comment thread openfeature/provider_repository.cpp Outdated
Comment thread openfeature/provider_repository.cpp Outdated
Comment thread openfeature/provider_repository.cpp Outdated
Comment thread openfeature/provider_repository.cpp Outdated
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
@NeaguGeorgiana23 NeaguGeorgiana23 merged commit d06cf55 into main Jan 5, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement Provider Repository

3 participants