Client API

[NeaguGeorgiana23]

This PR

• Implements ClientAPI class which is the concrete implementation of Client.
• Implements Boolean flag evaluation logic.

Related Issues

Fixes #34

[gemini-code-assist]

Summary of Changes

Hello @NeaguGeorgiana23, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly advances the OpenFeature C++ SDK by introducing foundational client-side feature flag evaluation capabilities. It establishes the ClientAPI for interacting with feature flags and a GlobalContextManager for managing application-wide evaluation contexts. The changes provide the initial structure for evaluating boolean flags and ensure a robust, thread-safe mechanism for context handling, setting the stage for more comprehensive feature flag support.

Highlights

• ClientAPI Implementation: Introduced ClientAPI as the concrete implementation of the Client interface, providing core feature flag evaluation capabilities.
• Boolean Flag Evaluation: Implemented the logic for evaluating boolean feature flags, including handling default values and provider status.
• Global Context Management: Added GlobalContextManager to handle a global EvaluationContext, ensuring thread-safe access and modification.
• Build System Updates: Updated Bazel build files to incorporate the new ClientAPI and GlobalContextManager components and their respective tests.
• Comprehensive Testing: Included new unit tests for both ClientAPI and GlobalContextManager, covering functionality, context handling, and thread safety.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces the ClientAPI as a concrete implementation of the Client interface, and adds the GlobalContextManager for handling global evaluation context. The changes include the implementation for boolean flag evaluation and corresponding build file updates and tests.

My review has identified a few issues:

• The context merging logic in ClientAPI is incomplete and does not adhere to the OpenFeature specification as it ignores the global context.
• The GlobalContextManager implementation has a missing header include which could lead to build failures on some platforms.
• A test file includes a main function which will conflict with the gtest_main library used in the build, causing a linker error.

Details and suggestions for these points are in the specific comments.

[gemini-code-assist]

The current implementation of MergeContexts doesn't follow the OpenFeature specification for context merging. It should merge contexts from the invocation, client, and API (global) levels. This implementation only considers the invocation and client contexts, ignoring the global context available via GlobalContextManager. While EvaluationContext is not fully implemented, the logic here should at least be structured to reflect the specified merging hierarchy (invocation > client > global) as a placeholder.

[oxddr]

LGTM, but let's have #52 merged before I approve this one.