feat: add release-please configuration and manifest with initial version 0.1.0#84
feat: add release-please configuration and manifest with initial version 0.1.0#84oxddr wants to merge 1 commit into
Conversation
…ion 0.1.0 Signed-off-by: Janek Łukaszewicz <janluk@google.com>
There was a problem hiding this comment.
Pull request overview
Adds Release Please configuration/manifest to restore automated releases on main.
Changes:
- Introduces
release-please-config.jsonwith a single-package (".")simplerelease strategy. - Adds
.release-please-manifest.jsonto seed the current release version (0.1.0).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
release-please-config.json |
Defines Release Please behavior for the root package. |
.release-please-manifest.json |
Seeds the version baseline used by Release Please to calculate next releases. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1,3 @@ | |||
| { | |||
| ".": "0.1.0" | |||
There was a problem hiding this comment.
The manifest version should match the latest already-released version/tag for the repo. README currently links to a v0.0.1 release, but the manifest is initialized to 0.1.0, which will cause release-please to compute subsequent versions from the wrong baseline (e.g., start bumping from 0.1.0 even if 0.0.1 is the current release). Consider setting this to the current released version, or updating existing release/tag references if 0.1.0 is intended to be the baseline.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request establishes an automated release management system using Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces configuration for release-please to automate the release process. It adds a manifest file with an initial version and a configuration file. The changes are a good starting point. My review includes suggestions to add JSON schemas to these files, which will improve maintainability and provide editor support for validation and auto-completion.
Note: Security Review has been skipped due to the limited scope of the PR.
| { | ||
| ".": "0.1.0" | ||
| } No newline at end of file |
There was a problem hiding this comment.
It's beneficial to include the $schema for this manifest file. It helps with validation and editor tooling. Additionally, it's a common convention to end files with a newline character.
| { | |
| ".": "0.1.0" | |
| } | |
| { | |
| "$schema": "https://raw.githubusercontent.com/googleapis/release-please/main/schemas/manifest.json", | |
| ".": "0.1.0" | |
| } | |
| { | ||
| "packages": { | ||
| ".": { | ||
| "release-type": "simple", | ||
| "bump-minor-pre-major": true, | ||
| "bump-patch-for-minor-pre-major": true | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
To improve maintainability and provide editor support (like auto-completion and validation), it's a good practice to add a $schema key to your release-please-config.json file. This helps prevent typos and ensures the configuration is valid.
| { | |
| "packages": { | |
| ".": { | |
| "release-type": "simple", | |
| "bump-minor-pre-major": true, | |
| "bump-patch-for-minor-pre-major": true | |
| } | |
| } | |
| } | |
| { | |
| "$schema": "https://raw.githubusercontent.com/googleapis/release-please/main/schemas/config.json", | |
| "packages": { | |
| ".": { | |
| "release-type": "simple", | |
| "bump-minor-pre-major": true, | |
| "bump-patch-for-minor-pre-major": true | |
| } | |
| } | |
| } | |
This should hopefully fix broken release workflow.