feat: extract core flagd evaluation and API modules#1696
Open
feat: extract core flagd evaluation and API modules#1696
Conversation
github-actions
bot
requested review from
Kavindu-Dodan,
beeme1mr and
thisthat
Contributor
Summary of ChangesHello @toddbaert, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refactors the flagd provider by extracting its in-process flag evaluation capabilities into dedicated, reusable modules: Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a significant and well-executed refactoring by extracting the core flag evaluation logic into new flagd-api and flagd-core modules. This improves modularity and aligns with the architecture of other flagd SDKs. The changes also include updating to grpc-netty-shaded to prevent dependency conflicts, which is a great improvement for a library. The tests have been diligently updated to reflect these architectural changes.
I have found one critical issue in the new flagd-core module where change detection for removed flags is missing. This will prevent consumers from being notified of flag deletions. A detailed comment with a suggested fix is provided.
tools/flagd-core/src/main/java/dev/openfeature/contrib/tools/flagd/core/FlagdCore.java
Show resolved
Hide resolved
toddbaert
changed the title
toddbaert
changed the title
toddbaert
force-pushed
the
feat/extract-core
branch
2 times, most recently
from
2f7202f to
c0421e1
Compare
toddbaert
force-pushed
the
feat/extract-core
branch
2 times, most recently
from
3daa738 to
c8ec1d4
Compare
toddbaert
force-pushed
the
feat/extract-core
branch
from
c8ec1d4 to
73fda14
Compare
toddbaert
commented
Feb 11, 2026
| : new SyncStreamQueueSource(options); | ||
| } | ||
|
|
||
| private <T> ProviderEvaluation<T> resolve(Class<T> type, String key, EvaluationContext ctx) { |
Member
Author
There was a problem hiding this comment.
This is one of the few things that weren't moved 1:1
This class was eliminated because FlagdCore now handles flag storage internally and includes the metadata in evaluation results directly. The StorageQueryResult intermediary is no longer needed.
toddbaert
force-pushed
the
feat/extract-core
branch
from
73fda14 to
06112b2
Compare
toddbaert
commented
Feb 11, 2026
| * Interface for in-process flag evaluation in flagd. | ||
| * Combines flag storage and evaluation into a single abstraction. | ||
| */ | ||
| public interface Evaluator { |
Member
Author
There was a problem hiding this comment.
This new interface is equivalent to that in JS' flagd core, and the Go equivalent - though only the minimal features have been implemented (we don't need bulk evaluation here).
toddbaert
force-pushed
the
feat/extract-core
branch
from
06112b2 to
f51baa8
Compare
toddbaert
commented
Feb 11, 2026
| for module in "${modules[@]}" | ||
| do | ||
| mvn --batch-mode --projects $module --settings release/m2-settings.xml -DskipTests -Dcheckstyle.skip clean deploy | ||
| mvn --batch-mode --projects $module --settings release/m2-settings.xml -DskipTests -Dcheckstyle.skip -Dflagd-core.version=$FLAGD_CORE_VERSION clean deploy |
Member
Author
There was a problem hiding this comment.
This pins the flagd-core dep in the flagd-provider to the current version in source, ensuring we never have incompatibility.
toddbaert
force-pushed
the
feat/extract-core
branch
3 times, most recently
from
837eb0a to
f7a5c66
Compare
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
toddbaert
force-pushed
the
feat/extract-core
branch
from
f7a5c66 to
bcfae8a
Compare
aepfli
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extraction of the core evaluator of flagd into 2 modules:
I've also included some basic automation to make sure the local version of flagd-core is always resolved in development, and at provider release the dep is pinned to exactly what is present locally.
I've intentionally made as few changes as possible, and made no functional changes; note that a large volume of the changes are
git mvoperations.Fixes: #1695