-
Notifications
You must be signed in to change notification settings - Fork 94
fix(ui): resolve search input overlap caused by tailwind forms #1330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…overlap Signed-off-by: Dedy F. Setyawan <dedyfajars@gmail.com>
✅ Deploy Preview for openfeature ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Summary of ChangesHello @dedyf5, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a visual bug within the documentation search modal where the focus ring of the search input field obscured the "Clear the query" label. The problem stemmed from a global style applied by the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request effectively resolves a UI bug where the search input's focus ring, added by @tailwindcss/forms, was overlapping with other elements. The fix is targeted and correct, overriding the specific CSS properties causing the issue for the .DocSearch-Input component. I've added one suggestion to include a comment in the CSS to improve long-term maintainability by explaining the purpose of this override. Overall, this is a good, clean fix.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
|
Thanks @dedyf5 |
This PR
This PR fixes a visual bug where the search input field in the documentation modal overlaps with the "Clear the query" label.
The issue was caused by the
@tailwindcss/formsplugin, which applies a global focus ring (box-shadowand--tw-ring-shadow) to all[type="search"]elements. This ring was obscuring the internal UI elements of the Algolia DocSearch component..DocSearch-Input:focusincustom.css.--tw-ring-offset-shadow,--tw-ring-shadow, andbox-shadowtononefor the search input.Related Issues
N/A
Notes
Screenshots:
Follow-up Tasks
N/A
How to test
yarn start.