chore: align unleash pyproject.toml to others

[gruebel]

This PR

• main change was the ruff usage

[gemini-code-assist]

Summary of Changes

Hello @gruebel, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on aligning the pyproject.toml configuration for the Unleash provider with common practices across the repository, particularly regarding ruff linting. It centralizes or simplifies ruff configuration by removing local settings and introduces specific noqa directives in test files to manage linting warnings. Additionally, it improves logging practices in integration tests by replacing direct print statements with structured logging, and updates pyproject.toml with modern license declarations and forward-looking mypy settings.

Highlights

• Ruff Configuration Centralization/Simplification: The [tool.ruff] section was removed from pyproject.toml, indicating a shift in how ruff linting is configured for this provider, likely moving to a global or more streamlined approach.
• Linting Rule Exemptions: Several noqa directives were added to test files (S106, S105, S104, PLR0915, PERF203) to suppress specific ruff and pylint warnings, accommodating the new linting setup.
• Improved Logging in Integration Tests: print statements in test_integration.py were replaced with logging.info and logging.error calls, enhancing the observability and maintainability of test output.
• Pyproject.toml Updates: The pyproject.toml file was updated to use the modern license and license-files fields, and new mypy configuration options (allow_redefinition_new, fixed_format_cache) were added.

Changelog

• providers/openfeature-provider-unleash/pyproject.toml
  • Updated license declaration to use license = "Apache-2.0" and license-files = ["LICENSE"].
  • Removed source-exclude configuration for openfeature/py.typed.
  • Added allow_redefinition_new = true and fixed_format_cache = true to [tool.mypy].
  • Removed the entire [tool.ruff] configuration section.
• providers/openfeature-provider-unleash/tests/test_events.py
  • Removed module docstring.
  • Added # ruff: noqa: S106 at the top of the file.
  • Added # noqa: PLR0915 to test_events function definition.
• providers/openfeature-provider-unleash/tests/test_flag_evaluation.py
  • Removed module docstring.
  • Added # ruff: noqa: S106 at the top of the file.
• providers/openfeature-provider-unleash/tests/test_integration.py
  • Imported the logging module.
  • Replaced print statements with logger.info and logger.error for better logging.
  • Added noqa directives (S105, S104, PERF203, PLR0915) to suppress specific linting warnings.
• providers/openfeature-provider-unleash/tests/test_provider.py
  • Added # ruff: noqa: S106 at the top of the file.

Activity

• The pull request was created by gruebel.
• The PR description indicates the main change was related to ruff usage.
• No other human activity (comments, reviews) has been recorded yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request aligns the pyproject.toml for the Unleash provider with others in the repository, primarily by removing the [tool.ruff] configuration as it's handled by pre-commit hooks. This is a good cleanup. Additionally, the test files have been improved by replacing print statements with logging, which is a great enhancement for test output. Several noqa comments have been added to suppress ruff warnings that are acceptable in a test context.

My main feedback is about module docstrings in test files. In a few files, existing docstrings were removed, and in another, a docstring is missing. I've suggested adding/restoring them to improve maintainability, as they provide a quick overview of the file's purpose.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.70%. Comparing base (8239b83) to head (ad9451f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #341      +/-   ##
==========================================
+ Coverage   95.65%   98.70%   +3.05%     
==========================================
  Files          30        3      -27     
  Lines        1426      155    -1271     
==========================================
- Hits         1364      153    -1211     
+ Misses         62        2      -60     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.