Skip to content

feat: Add targeting match split #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GStrawinsky wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: Add targeting match split #256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ed48a9
add targeting match split
GStrawinsky Mar 26, 2026
becfee7
reason typo
GStrawinsky Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/open_feature/sdk/provider/reason.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ module Reason
STATIC = "STATIC"
DEFAULT = "DEFAULT"
TARGETING_MATCH = "TARGETING_MATCH"
TARGETING_MATCH_SPLIT = "TARGETING_MATCH_SPLIT"
SPLIT = "SPLIT"
CACHED = "CACHED"
DISABLED = "DISABLED"
Expand Down
1 change: 1 addition & 0 deletions sig/open_feature/sdk/provider/reason.rbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ module OpenFeature
SPLIT: String
CACHED: String
DISABLED: String
TARGETING_MATCH_SPLIT: String
Comment on lines 8 to +11
Copy link

Copilot AI Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the RBS signature, TARGETING_MATCH_SPLIT is inserted after DISABLED, but in the Ruby implementation it’s placed right after TARGETING_MATCH. Keeping the constant order consistent between reason.rb and reason.rbs makes it easier to diff/scan and reduces the chance of missing future updates—please move the RBS constant to match the Ruby ordering.

Suggested change
SPLIT: String
CACHED: String
DISABLED: String
TARGETING_MATCH_SPLIT: String
TARGETING_MATCH_SPLIT: String
SPLIT: String
CACHED: String
DISABLED: String

Copilot uses AI. Check for mistakes.
UNKNOWN: String
STALE: String
ERROR: String
Expand Down
Loading