Added data padding to 'forward', 'inference', and 'get_prosody_featur…#189
Open
norabai wants to merge 1 commit intoopen-mmlab:mainfrom
Open
Added data padding to 'forward', 'inference', and 'get_prosody_featur…#189norabai wants to merge 1 commit intoopen-mmlab:mainfrom
norabai wants to merge 1 commit intoopen-mmlab:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Issue #188
✨ Description
This PR adds data padding functionality to the
forward,inference, andget_prosody_featuremethods in our model class. The_pad_datafunction pads the input audio tensor, making sure that its last dimension is a multiple of the hop length. This is common in audio processing where all frames need to have equal lengths for certain computations or analyses.To test this PR, run any processes that use the
forward,inference, andget_prosody_featuremethods and observe if there are any issues or improvements with how the processed audio data aligns with the hop length.🚧 Related Issues
👨💻 Changes Proposed
_pad_datamethod which pads an input tensor along its last dimension.forward,inference, andget_prosody_featuremethods to use_pad_data.🧑🤝🧑 Who Can Review?
🛠 TODO
✅ Checklist