Ensure UTF-8 encoding for file reads to support Windows MaskGCT inference#408
Open
Sadler2 wants to merge 1 commit intoopen-mmlab:mainfrom
Open
Ensure UTF-8 encoding for file reads to support Windows MaskGCT inference#408Sadler2 wants to merge 1 commit intoopen-mmlab:mainfrom
Sadler2 wants to merge 1 commit intoopen-mmlab:mainfrom
Conversation
…ence This patch explicitly sets `encoding="utf-8"` when reading JSON files to prevent encoding issues on Windows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description
Before this fix, MaskGCT TTS produced unintelligible sounds instead of meaningful speech during inference on Windows. The issue was caused by reading JSON files without explicitly specifying UTF-8 encoding.
On systems where Python's default encoding is not set to UTF-8, this led to incorrect parsing of vocabulary/phoneme data, tampering the speech synthesis process.
before_and_after.zip
🚧 Related Issues
#327
https://github.com/justinjohn0306/MaskGCT-Windows