Improve error handling for perspectives Lambda errors#54
Merged
birgelee merged 1 commit intoopen-mpic:mainfrom Apr 10, 2025
Merged
Improve error handling for perspectives Lambda errors#54birgelee merged 1 commit intoopen-mpic:mainfrom
birgelee merged 1 commit intoopen-mpic:mainfrom
Conversation
Member
|
@hablutzel1 this looks great thanks. I agree about the point of the service being internal to CAs justifying the full error response. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when making a simple request like:
a failure occurs within the perspectives Lambda and the returned error response looks like this:
Where the error doesn't provide too much useful information.
With this update, the full error details are provided, including the Lambda execution exception and stack trace:
Although returning the complete stack trace may seem excessive, I think it accelerates debugging and since this service is internal to the CAs, exposing detailed errors in responses might be considered safe.