chore: Update CI Helm tooling to Helm 4.x#4622
Conversation
Fixes open-policy-agent#4605 Signed-off-by: Mallikarjunadevops <muchu.mallikarjunarpa@gmail.com>
|
Since this PR updates the Helm CI tooling to v4.x, the primary testing evidence will be the successful execution of our automated CI workflows ( Once the CI checks on this PR pass, it will confirm that Helm 4.2.1 handles our charts without any breaking changes. |
There was a problem hiding this comment.
Pull request overview
This PR updates the Helm version used in CI tooling from Helm 3.x to Helm 4.x (4.2.1) in preparation for Helm 3 end-of-life, as tracked by issue #4605. The change touches the Makefile and two workflow files to update the Helm version pins.
Changes:
- Updated
HELM_VERSIONfrom3.17.4to4.2.1in the Makefile. - Updated the Helm version matrix entries in
workflow.yamlandupgrade.yamlfrom3.14.1to4.2.1.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
Makefile |
Updated HELM_VERSION default from 3.17.4 to 4.2.1. |
.github/workflows/workflow.yaml |
Updated HELM_VERSION matrix entry from 3.14.1 to 4.2.1 for the Helm build-and-test job. |
.github/workflows/upgrade.yaml |
Updated HELM_VERSION matrix entry from 3.14.1 to 4.2.1 for the Helm upgrade-test job. |
| fail-fast: false | ||
| matrix: | ||
| HELM_VERSION: ["3.14.1"] | ||
| HELM_VERSION: ["4.2.1"] |
There was a problem hiding this comment.
@Mallikarjunadevops this is a valid concern, can you address this?
| fail-fast: false | ||
| matrix: | ||
| HELM_VERSION: ["3.14.1"] | ||
| HELM_VERSION: ["4.2.1"] |
|
@Mallikarjunadevops can you resolve conflicts? |
|
@JaydipGabani The conflicts with |
| fail-fast: false | ||
| matrix: | ||
| HELM_VERSION: ["3.14.1"] | ||
| HELM_VERSION: ["4.2.1"] |
There was a problem hiding this comment.
@Mallikarjunadevops this is a valid concern, can you address this?
| make e2e-bootstrap KUBERNETES_VERSION=${{ env.KUBERNETES_VERSION }} | ||
| env: | ||
| KUBERNETES_VERSION: 1.24.4 | ||
| KUBERNETES_VERSION: 1.33.2 |
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #4622 +/- ##
==========================================
- Coverage 54.49% 44.86% -9.64%
==========================================
Files 134 284 +150
Lines 12329 21041 +8712
==========================================
+ Hits 6719 9439 +2720
- Misses 5116 10794 +5678
- Partials 494 808 +314
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
5c6221a to
ab4434c
Compare
| make e2e-bootstrap KUBERNETES_VERSION=${{ env.KUBERNETES_VERSION }} | ||
| env: | ||
| KUBERNETES_VERSION: 1.24.4 | ||
| KUBERNETES_VERSION: 1.33.2 |
| KIND_CLUSTER_FILE ?= "" | ||
| # note: k8s version pinned since KIND image availability lags k8s releases | ||
| KUBERNETES_VERSION ?= 1.33.0 | ||
| KUBERNETES_VERSION ?= 1.33.2 |
| make e2e-bootstrap KUBERNETES_VERSION=${{ env.KUBERNETES_VERSION }} | ||
| env: | ||
| KUBERNETES_VERSION: 1.24.4 | ||
| KUBERNETES_VERSION: 1.33.2 |
| steps: | ||
| - name: Harden Runner | ||
| uses: step-security/harden-runner@9af89fc71515a100421586dfdb3dc9c984fbf411 # v2.19.4 | ||
| with: | ||
| egress-policy: audit | ||
|
|
||
| - name: Check out code into the Go module directory |
| make e2e-bootstrap KUBERNETES_VERSION=${{ env.KUBERNETES_VERSION }} | ||
| env: | ||
| KUBERNETES_VERSION: 1.24.4 | ||
| KUBERNETES_VERSION: 1.33.2 |
Signed-off-by: Mallikarjunadevops <muchu.mallikarjunarpa@gmail.com>
50c665b to
4be0a8e
Compare
|
I have updated the PR to cleanly bump the Helm version to However, for the Regarding the 2 CI test cancellations ( I have left the code simple for now without workarounds so you can review and decide the best way to address this Helm 4 behavior for Gatekeeper. |
| fail-fast: false | ||
| matrix: | ||
| HELM_VERSION: ["3.17.4"] | ||
| HELM_VERSION: ["4.2.1"] |
Signed-off-by: Mallikarjunadevops <muchu.mallikarjunarpa@gmail.com>
Hey maintainers! 👋
This PR addresses issue #4605 by updating the Helm version in our CI tooling to
4.2.1(the latest v4 release). As noted in the Helm v3.21.0 release notes, Helm 3 is approaching EOL and we should migrate our pipelines to use v4.x.Changes Made:
HELM_VERSIONfrom3.17.4to4.2.1in theMakefile..github/workflows/upgrade.yamland.github/workflows/workflow.yamlto use4.2.1.These changes ensure that all our lint, build, test, and upgrade jobs will now run using Helm 4.x and catch any potential incompatibilities moving forward.
Fixes #4605
Thanks for reviewing! Let me know if there's anything else needed.