Fix icons - #563
Merged
Merged
Conversation
…from MainWindow class
…s in the *_ui.py files
…s the mpltoolbar folder
…rop redundant per-widget theme repainting
R0drigoSchwartz
added
Optimization 🏎️
Collaborator
|
I noticed a small color difference of the icons compared to the logos. The dark theme is BLUE_7 (#84AAFF) and the light theme is BLUE_3 (#0051A2) 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR changes the icon approach. Previously, whenever the theme changed, we would manually color the icons by iterating over them.
We now have two resource files: one for the dark theme and another for the light theme. If we want to change the icon colors, we simply need to modify the
DARK_ICON_COLORandLIGHT_ICON_COLORconstants in the__init__.pyfile. Then, we can run thepaint_icons.pyscript located in thescriptsfolder. This script will color all the icons in thelight_themeanddark_themefolders and subsequently generate two new resource files containing the colored icons. If the theme changes, we just need to change the resource file.Closes #562