Replace logos - #567
Merged
Merged
Conversation
Collaborator
|
I will already merge this PR so Rodrigo can fix the expected conflicts as soon as possible |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OP logos, which were generated from text (HTML inside a QLabel), were replaced with PNG file. In the splash screen and welcome widget, the logo is now loaded as a QPixmap and scaled with the device pixel ratio applied, preserving sharpness. In the geometry, mesh and results render widgets, the hardcoded viewport coordinates were removed. The layout is now computed from the image dimensions, preserving the aspect ratio and is recomputed by a StartEvent observer whenever the render window resized.
