Skip to content

Change parameter types #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FlorianK13 merged 2 commits into from
Mar 11, 2026
Merged

Change parameter types #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
533378b
Change parameter types #80
FlorianK13 Jan 27, 2026
28d7b2e
Remove broken link #80
FlorianK13 Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ import * as triangleUtils from './triangleUtils.js';
import { CalculateParams, CartesianPoint, ColorMap, SolarIrradianceData, logNaNCount } from './utils.js';

// @ts-ignore
import { rayTracingWebGL } from './rayTracingWebGL.js';
import { filterShadingBufferGeometry, filterShadingGeometry, getMinSunAngleFromIrradiance } from './geometryFilter';
import { rayTracingWebGL } from './rayTracingWebGL.js';

/**
* This class holds all information about the scene that is simulated.
Expand All @@ -36,7 +36,7 @@ export class ShadingScene {
/**
* The minimum radiance angle which gets used during raytracing.
* It is being used for filtering out shading geometry which
* physically cannot shade the simulation geometry. See {@link filterShadingGeometry}
* physically cannot shade the simulation geometry.
*/
public minSunAngle: number | undefined;
/**
Expand Down
4 changes: 2 additions & 2 deletions src/rayTracingWebGL.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,8 +335,8 @@ function makeTransformFeedback(gl: WebGL2RenderingContext, buffer: WebGLBuffer |
return tf;
}

function makeBufferAndSetAttribute(gl: WebGL2RenderingContext, data: ArrayBuffer, loc: number): WebGLBuffer | null {
const buf = makeBuffer(gl, data);
function makeBufferAndSetAttribute(gl: WebGL2RenderingContext, data: TypedArray, loc: number): WebGLBuffer | null {
const buf = makeBuffer(gl, data as BufferSource);
// setup our attributes to tell WebGL how to pull
// the data from the buffer above to the attribute
gl.enableVertexAttribArray(loc);
Expand Down
Loading