Skip to content

Fix shading bugs on Linux systems#82

Merged
FlorianK13 merged 4 commits intoopen-pv:mainfrom
mestr01:main
Feb 13, 2026
Merged

Fix shading bugs on Linux systems#82
FlorianK13 merged 4 commits intoopen-pv:mainfrom
mestr01:main

Conversation

@mestr01
Copy link
Contributor

@mestr01 mestr01 commented Feb 13, 2026

On Unix machines the default precision for integers and sampler2D units is too small for large geometries. To increase the precision is necessary for CLI usage.

The second fix shifts the simulation and shading geometry to the coordinate origin. This fixes problems when working with large coordinates e.g. UTM formats. It can occure self shading due to rounding errors without this fix. After the simulation the simulation geometry gets shifted back to its original position.

Also, the PR contains a minor fix for the V8 heap size handling.

@mestr01
Copy link
Contributor Author

mestr01 commented Feb 13, 2026

@FlorianK13

@FlorianK13 FlorianK13 self-requested a review February 13, 2026 10:20
Copy link
Member

@FlorianK13 FlorianK13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FlorianK13 FlorianK13 merged commit d2381d6 into open-pv:main Feb 13, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants