Add Python requests to alpine and ubuntu-jammy Dockerfile#97
Conversation
Signed-off-by: Ganyu (Bruce) Xu <g66xu@uwaterloo.ca>
baentsch
left a comment
There was a problem hiding this comment.
Thanks & LGTM. Only question: Is it worth while keeping supporting Ubuntu Jammy in CI? (Where) Do we promise (doing) that?
Same question regarding Alpine. If it's a fully supported platform, it should also have automated build-and-push in this project. |
@baentsch I don't have a good answer, but I am happy to raise an issue for "reviewing platform test matrix". From edit: #78 is very closely related to this discussion. |
|
@xuganyu96 I already created open-quantum-safe/liboqs#2304 to track. And indeed #78 is pretty much the same thing. Time to finally address it: I was unhappy to see that you still had to grapple with CI image issues this long after the problem had been identified :-( |
Some jobs in this CI run failed because
openquantumsafe/ci-alpine-amd64:latestandopenquantumsafe/ci-ubuntu-jammy:latestdo not have therequestsPython package. Theubuntu-latestimage does have this package, so the CI tests passed.This pull request adds the step to install
requestsin the aforementioned Docker images.