Skip to content

Add Python requests to alpine and ubuntu-jammy Dockerfile#97

Merged
baentsch merged 1 commit intomainfrom
gyx-add-python-requests
Oct 23, 2025
Merged

Add Python requests to alpine and ubuntu-jammy Dockerfile#97
baentsch merged 1 commit intomainfrom
gyx-add-python-requests

Conversation

@xuganyu96
Copy link
Copy Markdown
Contributor

Some jobs in this CI run failed because openquantumsafe/ci-alpine-amd64:latest and openquantumsafe/ci-ubuntu-jammy:latest do not have the requests Python package. The ubuntu-latest image does have this package, so the CI tests passed.

This pull request adds the step to install requests in the aforementioned Docker images.

Signed-off-by: Ganyu (Bruce) Xu <g66xu@uwaterloo.ca>
@xuganyu96 xuganyu96 requested review from a team, baentsch and dstebila October 22, 2025 19:05
Copy link
Copy Markdown
Member

@baentsch baentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks & LGTM. Only question: Is it worth while keeping supporting Ubuntu Jammy in CI? (Where) Do we promise (doing) that?

@baentsch baentsch merged commit 6eb6560 into main Oct 23, 2025
12 of 14 checks passed
@baentsch
Copy link
Copy Markdown
Member

Thanks & LGTM. Only question: Is it worth while keeping supporting Ubuntu Jammy in CI? (Where) Do we promise (doing) that?

Same question regarding Alpine. If it's a fully supported platform, it should also have automated build-and-push in this project.

@xuganyu96
Copy link
Copy Markdown
Contributor Author

xuganyu96 commented Oct 23, 2025

Thanks & LGTM. Only question: Is it worth while keeping supporting Ubuntu Jammy in CI? (Where) Do we promise (doing) that?

Same question regarding Alpine. If it's a fully supported platform, it should also have automated build-and-push in this project.

@baentsch I don't have a good answer, but I am happy to raise an issue for "reviewing platform test matrix".

From open-quantum-safe/liboqs/PLATFORMS.md it seems like Ubuntu Jammy (i.e. 22.04) and Alpine are not even on the tier list. We might need to either update the tier list, or sunset CI tests on Ubuntu Jammy and/or Alpine.

edit: #78 is very closely related to this discussion.

cc: @dstebila @bhess

@xuganyu96 xuganyu96 deleted the gyx-add-python-requests branch October 23, 2025 14:45
@baentsch
Copy link
Copy Markdown
Member

@xuganyu96 I already created open-quantum-safe/liboqs#2304 to track. And indeed #78 is pretty much the same thing. Time to finally address it: I was unhappy to see that you still had to grapple with CI image issues this long after the problem had been identified :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants