Update CI to Humble#48
Merged
luca-della-vedova merged 12 commits intofeature/rmf_obstaclefrom Sep 2, 2022
Merged
Conversation
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
Member
|
Could you also copy over the style CI? And update the readme to display both badges |
Member
|
And wondering if this should target the |
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
Member
Author
|
All done! Retargeting the rmf_obstacle branch, had to add a few code style changes (result of CI is now green, merging this in the |
Yadunund
reviewed
Sep 2, 2022
Member
Yadunund
left a comment
There was a problem hiding this comment.
Thanks for tackling this issue. Looks good! Just have one very tiny nitpick on what uncrustify did
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
Yadunund
approved these changes
Sep 2, 2022
Yadunund
added a commit
that referenced
this pull request
Sep 7, 2022
* Added publisher for human markers Signed-off-by: Yadunund <yadunund@gmail.com> * Set level and frame name through params Signed-off-by: Yadunund <yadunund@openrobotics.org> * Bbox from Obstacle Signed-off-by: Yadunund <yadunund@openrobotics.org> * Remove ObstacleData Signed-off-by: Yadunund <yadunund@gmail.com> * Skeleton for navgraph visualization Signed-off-by: Yadunund <yadunund@gmail.com> * Create sub Signed-off-by: Yadunund <yadunund@gmail.com> * Remove data struct Signed-off-by: Yadunund <yadunund@gmail.com> * Make obstacle visualizer a component Signed-off-by: Yadunund <yadunund@gmail.com> * WIP Signed-off-by: Yadunund <yadunund@openrobotics.org> * Use rmf_traffic_ros2 convert api Signed-off-by: Yadunund <yadunund@openrobotics.org> * Navgraph publishing works with map change Signed-off-by: Yadunund <yadunund@openrobotics.org> * Publish waypoint markers Signed-off-by: Yadunund <yadunund@openrobotics.org> * Add more customizable parameters Signed-off-by: Yadunund <yadunund@openrobotics.org> * Update visuals for closed and speed limited lanes Signed-off-by: Yadunund <yadunund@openrobotics.org> * Fix transparency when opening lane Signed-off-by: Yadunund <yadunund@openrobotics.org> * Be more efficient of publishing lane marker updates Signed-off-by: Yadunund <yadunund@openrobotics.org> * Remove navgraph publishing from rmf_visualization_schedule Signed-off-by: Yadunund <yadunund@openrobotics.org> * Uncrustify Signed-off-by: Yadunund <yadunund@openrobotics.org> * Added skeleton for rmf_visualization_floorplan Signed-off-by: Yadunund <yadunund@openrobotics.org> * Add to launch file Signed-off-by: Yadunund <yadunund@openrobotics.org> * Cleanup rmf_visualization_schedule Signed-off-by: Yadunund <yadunund@openrobotics.org> * Converted schedule visualizer to component Signed-off-by: Yadunund <yadunund@gmail.com> * Finished porting schedule visualizer to component Signed-off-by: Yadunund <yadunund@gmail.com> * Use correct QoS Signed-off-by: Yadunund <yadunund@openrobotics.org> * Convert to cpp package Signed-off-by: Yadunund <yadunund@openrobotics.org> * Finish implementation Signed-off-by: Yadunund <yadunund@openrobotics.org> * Remove previous implementation Signed-off-by: Yadunund <yadunund@openrobotics.org> * Make nose scale a param Signed-off-by: Yadunund <yadunund@openrobotics.org> * Fix nose scale param Signed-off-by: Yadunund <yadunund@openrobotics.org> * Add obstacle visualizer to launch Signed-off-by: Yadunund <yadunund@openrobotics.org> * Grey out closed lanes Signed-off-by: Yadunund <yadunund@openrobotics.org> * Update text size Signed-off-by: Yadunund <yadunund@openrobotics.org> * Updated CI Signed-off-by: Yadunund <yadunund@openrobotics.org> * Fix nav_msgs dep and cleanup comments Signed-off-by: Yadunund <yadunund@openrobotics.org> * Update CI Signed-off-by: Yadunund <yadunund@gmail.com> * Use unique ns for obstacles Signed-off-by: Yadunund <yadunund@openrobotics.org> * Update CI to Humble (#48) Signed-off-by: Luca Della Vedova <luca@openrobotics.org> * Update README Signed-off-by: Yadunund <yadunund@gmail.com> * Bump version and update changelogs Signed-off-by: Yadunund <yadunund@gmail.com> * Remove extra newline Signed-off-by: Yadunund <yadunund@gmail.com> Signed-off-by: Yadunund <yadunund@gmail.com> Signed-off-by: Yadunund <yadunund@openrobotics.org> Signed-off-by: Luca Della Vedova <luca@openrobotics.org> Co-authored-by: Luca Della Vedova <luca@openrobotics.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fix
Fixed bug
Update CI to newest setup-ros action / Humble and Ubuntu Jammy, as done in open-rmf/rmf_simulation#77