Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
import io.opentelemetry.javaagent.extension.instrumentation.InstrumentationModule;
import io.opentelemetry.javaagent.extension.instrumentation.TypeInstrumentation;
import io.opentelemetry.javaagent.extension.instrumentation.internal.ExperimentalInstrumentationModule;
import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
import java.util.List;
import net.bytebuddy.matcher.ElementMatcher;

Expand All @@ -32,7 +31,7 @@ public ElementMatcher.Junction<ClassLoader> classLoaderMatcher() {
}

@Override
public boolean defaultEnabled(ConfigProperties config) {
public boolean defaultEnabled() {
// the Dropwizard metrics API does not have a concept of metric labels/tags/attributes, thus the
// data produced by this integration might be of very low quality, depending on how the API is
// used in the instrumented application
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,10 @@
import static java.util.Arrays.asList;

import com.google.auto.service.AutoService;
import io.opentelemetry.api.GlobalOpenTelemetry;
import io.opentelemetry.instrumentation.api.incubator.config.internal.DeclarativeConfigUtil;
import io.opentelemetry.javaagent.extension.instrumentation.InstrumentationModule;
import io.opentelemetry.javaagent.extension.instrumentation.TypeInstrumentation;
import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
import java.util.List;

@AutoService(InstrumentationModule.class)
Expand All @@ -21,10 +22,20 @@ public ApplicationLoggingInstrumentationModule() {
}

@Override
public boolean defaultEnabled(ConfigProperties config) {
public boolean defaultEnabled() {
// only enable this instrumentation if the application logger is enabled
return super.defaultEnabled(config)
&& "application".equals(config.getString("otel.javaagent.logging"));
String logging =
DeclarativeConfigUtil.getInstrumentationConfig(GlobalOpenTelemetry.get(), "agent")
Comment thread
zeitlinger marked this conversation as resolved.
.getString("logging");
return superDefaultEnabled() && "application".equals(logging);
}

// This method can be removed and super.defaultEnabled() can be used instead once the deprecated
// InstrumentationModule.defaultEnabled(ConfigProperties) is removed, at which point
// InstrumentationModule.defaultEnabled() will no longer need to throw an exception.
private static boolean superDefaultEnabled() {
return DeclarativeConfigUtil.getInstrumentationConfig(GlobalOpenTelemetry.get(), "common")
Comment thread
zeitlinger marked this conversation as resolved.
.getBoolean("default_enabled", true);
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
import io.opentelemetry.javaagent.extension.instrumentation.InstrumentationModule;
import io.opentelemetry.javaagent.extension.instrumentation.TypeInstrumentation;
import io.opentelemetry.javaagent.extension.instrumentation.internal.ExperimentalInstrumentationModule;
import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
import java.util.List;

@AutoService(InstrumentationModule.class)
Expand All @@ -22,7 +21,7 @@ public ClassLoaderInstrumentationModule() {
}

@Override
public boolean defaultEnabled(ConfigProperties config) {
public boolean defaultEnabled() {
// internal instrumentations are always enabled by default
return true;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
import io.opentelemetry.javaagent.extension.instrumentation.InstrumentationModule;
import io.opentelemetry.javaagent.extension.instrumentation.TypeInstrumentation;
import io.opentelemetry.javaagent.extension.instrumentation.internal.ExperimentalInstrumentationModule;
import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
import java.util.List;

@AutoService(InstrumentationModule.class)
Expand All @@ -22,7 +21,7 @@ public EclipseOsgiInstrumentationModule() {
}

@Override
public boolean defaultEnabled(ConfigProperties config) {
public boolean defaultEnabled() {
// internal instrumentations are always enabled by default
return true;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
import io.opentelemetry.javaagent.extension.instrumentation.InstrumentationModule;
import io.opentelemetry.javaagent.extension.instrumentation.TypeInstrumentation;
import io.opentelemetry.javaagent.extension.instrumentation.internal.ExperimentalInstrumentationModule;
import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
import java.util.Collections;
import java.util.List;

Expand All @@ -23,7 +22,7 @@ public LambdaInstrumentationModule() {
}

@Override
public boolean defaultEnabled(ConfigProperties config) {
public boolean defaultEnabled() {
// internal instrumentations are always enabled by default
return true;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
import io.opentelemetry.javaagent.extension.instrumentation.internal.ExperimentalInstrumentationModule;
import io.opentelemetry.javaagent.extension.instrumentation.internal.injection.ClassInjector;
import io.opentelemetry.javaagent.extension.instrumentation.internal.injection.InjectionMode;
import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
import java.util.List;

@AutoService(InstrumentationModule.class)
Expand All @@ -24,7 +23,7 @@ public ReflectionInstrumentationModule() {
}

@Override
public boolean defaultEnabled(ConfigProperties config) {
public boolean defaultEnabled() {
// internal instrumentations are always enabled by default
return true;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
import com.google.auto.service.AutoService;
import io.opentelemetry.javaagent.extension.instrumentation.InstrumentationModule;
import io.opentelemetry.javaagent.extension.instrumentation.TypeInstrumentation;
import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
import java.util.List;

@AutoService(InstrumentationModule.class)
Expand All @@ -20,7 +19,7 @@ public UrlClassLoaderInstrumentationModule() {
}

@Override
public boolean defaultEnabled(ConfigProperties config) {
public boolean defaultEnabled() {
// internal instrumentations are always enabled by default
return true;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,12 @@
import static net.bytebuddy.matcher.ElementMatchers.not;

import com.google.auto.service.AutoService;
import io.opentelemetry.api.GlobalOpenTelemetry;
import io.opentelemetry.instrumentation.api.incubator.config.internal.DeclarativeConfigUtil;
import io.opentelemetry.javaagent.bootstrap.internal.ExperimentalConfig;
import io.opentelemetry.javaagent.extension.instrumentation.InstrumentationModule;
import io.opentelemetry.javaagent.extension.instrumentation.TypeInstrumentation;
import io.opentelemetry.javaagent.extension.instrumentation.internal.ExperimentalInstrumentationModule;
import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
import java.util.List;
import net.bytebuddy.matcher.ElementMatcher;

Expand All @@ -37,11 +38,19 @@ public List<TypeInstrumentation> typeInstrumentations() {
}

@Override
public boolean defaultEnabled(ConfigProperties config) {
public boolean defaultEnabled() {
// This instrumentation produces controller telemetry and sets http route. Http route is set by
// this instrumentation only when it was not already set by a jax-rs framework instrumentation.
// This instrumentation uses complex type matcher, disabling it can improve startup performance.
return super.defaultEnabled(config) && ExperimentalConfig.get().controllerTelemetryEnabled();
return superDefaultEnabled() && ExperimentalConfig.get().controllerTelemetryEnabled();
}

// This method can be removed and super.defaultEnabled() can be used instead once the deprecated
// InstrumentationModule.defaultEnabled(ConfigProperties) is removed, at which point
// InstrumentationModule.defaultEnabled() will no longer need to throw an exception.
private static boolean superDefaultEnabled() {
return DeclarativeConfigUtil.getInstrumentationConfig(GlobalOpenTelemetry.get(), "common")
.getBoolean("default_enabled", true);
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,12 @@
import static java.util.Arrays.asList;

import com.google.auto.service.AutoService;
import io.opentelemetry.api.GlobalOpenTelemetry;
import io.opentelemetry.instrumentation.api.incubator.config.internal.DeclarativeConfigUtil;
import io.opentelemetry.javaagent.bootstrap.internal.ExperimentalConfig;
import io.opentelemetry.javaagent.extension.instrumentation.InstrumentationModule;
import io.opentelemetry.javaagent.extension.instrumentation.TypeInstrumentation;
import io.opentelemetry.javaagent.extension.instrumentation.internal.ExperimentalInstrumentationModule;
import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
import java.util.List;
import net.bytebuddy.matcher.ElementMatcher;

Expand All @@ -40,11 +41,19 @@ public List<TypeInstrumentation> typeInstrumentations() {
}

@Override
public boolean defaultEnabled(ConfigProperties config) {
public boolean defaultEnabled() {
// This instrumentation produces controller telemetry and sets http route. Http route is set by
// this instrumentation only when it was not already set by a jax-rs framework instrumentation.
// This instrumentation uses complex type matcher, disabling it can improve startup performance.
return super.defaultEnabled(config) && ExperimentalConfig.get().controllerTelemetryEnabled();
return superDefaultEnabled() && ExperimentalConfig.get().controllerTelemetryEnabled();
}

// This method can be removed and super.defaultEnabled() can be used instead once the deprecated
// InstrumentationModule.defaultEnabled(ConfigProperties) is removed, at which point
// InstrumentationModule.defaultEnabled() will no longer need to throw an exception.
private static boolean superDefaultEnabled() {
return DeclarativeConfigUtil.getInstrumentationConfig(GlobalOpenTelemetry.get(), "common")
.getBoolean("default_enabled", true);
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,12 @@
import static java.util.Arrays.asList;

import com.google.auto.service.AutoService;
import io.opentelemetry.api.GlobalOpenTelemetry;
import io.opentelemetry.instrumentation.api.incubator.config.internal.DeclarativeConfigUtil;
import io.opentelemetry.javaagent.bootstrap.internal.ExperimentalConfig;
import io.opentelemetry.javaagent.extension.instrumentation.InstrumentationModule;
import io.opentelemetry.javaagent.extension.instrumentation.TypeInstrumentation;
import io.opentelemetry.javaagent.extension.instrumentation.internal.ExperimentalInstrumentationModule;
import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
import java.util.List;
import net.bytebuddy.matcher.ElementMatcher;

Expand All @@ -40,11 +41,19 @@ public List<TypeInstrumentation> typeInstrumentations() {
}

@Override
public boolean defaultEnabled(ConfigProperties config) {
public boolean defaultEnabled() {
// This instrumentation produces controller telemetry and sets http route. Http route is set by
// this instrumentation only when it was not already set by a jax-rs framework instrumentation.
// This instrumentation uses complex type matcher, disabling it can improve startup performance.
return super.defaultEnabled(config) && ExperimentalConfig.get().controllerTelemetryEnabled();
return superDefaultEnabled() && ExperimentalConfig.get().controllerTelemetryEnabled();
}

// This method can be removed and super.defaultEnabled() can be used instead once the deprecated
// InstrumentationModule.defaultEnabled(ConfigProperties) is removed, at which point
// InstrumentationModule.defaultEnabled() will no longer need to throw an exception.
private static boolean superDefaultEnabled() {
return DeclarativeConfigUtil.getInstrumentationConfig(GlobalOpenTelemetry.get(), "common")
.getBoolean("default_enabled", true);
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,12 @@
package io.opentelemetry.javaagent.instrumentation.jaxws.jws.v1_1;

import com.google.auto.service.AutoService;
import io.opentelemetry.api.GlobalOpenTelemetry;
import io.opentelemetry.instrumentation.api.incubator.config.internal.DeclarativeConfigUtil;
import io.opentelemetry.javaagent.bootstrap.internal.ExperimentalConfig;
import io.opentelemetry.javaagent.extension.instrumentation.InstrumentationModule;
import io.opentelemetry.javaagent.extension.instrumentation.TypeInstrumentation;
import io.opentelemetry.javaagent.extension.instrumentation.internal.ExperimentalInstrumentationModule;
import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
import java.util.Collections;
import java.util.List;

Expand All @@ -28,9 +29,17 @@ public List<TypeInstrumentation> typeInstrumentations() {
}

@Override
public boolean defaultEnabled(ConfigProperties config) {
public boolean defaultEnabled() {
// this instrumentation only produces controller telemetry
return super.defaultEnabled(config) && ExperimentalConfig.get().controllerTelemetryEnabled();
return superDefaultEnabled() && ExperimentalConfig.get().controllerTelemetryEnabled();
}

// This method can be removed and super.defaultEnabled() can be used instead once the deprecated
// InstrumentationModule.defaultEnabled(ConfigProperties) is removed, at which point
// InstrumentationModule.defaultEnabled() will no longer need to throw an exception.
private static boolean superDefaultEnabled() {
return DeclarativeConfigUtil.getInstrumentationConfig(GlobalOpenTelemetry.get(), "common")
.getBoolean("default_enabled", true);
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
import io.opentelemetry.javaagent.extension.instrumentation.InstrumentationModule;
import io.opentelemetry.javaagent.extension.instrumentation.TypeInstrumentation;
import io.opentelemetry.javaagent.extension.instrumentation.internal.ExperimentalInstrumentationModule;
import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
import java.util.List;

@AutoService(InstrumentationModule.class)
Expand All @@ -27,7 +26,7 @@ public List<TypeInstrumentation> typeInstrumentations() {
}

@Override
public boolean defaultEnabled(ConfigProperties config) {
public boolean defaultEnabled() {
return false;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
import io.opentelemetry.javaagent.extension.instrumentation.internal.ExperimentalInstrumentationModule;
import io.opentelemetry.javaagent.extension.instrumentation.internal.injection.ClassInjector;
import io.opentelemetry.javaagent.extension.instrumentation.internal.injection.InjectionMode;
import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
import java.util.List;
import net.bytebuddy.matcher.ElementMatcher;

Expand All @@ -27,7 +26,7 @@ public MicrometerInstrumentationModule() {
}

@Override
public boolean defaultEnabled(ConfigProperties config) {
public boolean defaultEnabled() {
// produces a lot of metrics that are already captured - e.g. JVM memory usage
return false;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
import io.opentelemetry.javaagent.extension.instrumentation.InstrumentationModule;
import io.opentelemetry.javaagent.extension.instrumentation.TypeInstrumentation;
import io.opentelemetry.javaagent.extension.instrumentation.internal.ExperimentalInstrumentationModule;
import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
import java.util.List;

@AutoService(InstrumentationModule.class)
Expand All @@ -28,7 +27,7 @@ public List<TypeInstrumentation> typeInstrumentations() {
}

@Override
public boolean defaultEnabled(ConfigProperties config) {
public boolean defaultEnabled() {
return false;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
import io.opentelemetry.javaagent.instrumentation.spring.batch.v3_0.job.JobFactoryBeanInstrumentation;
import io.opentelemetry.javaagent.instrumentation.spring.batch.v3_0.job.JobParserJobFactoryBeanInstrumentation;
import io.opentelemetry.javaagent.instrumentation.spring.batch.v3_0.step.StepBuilderHelperInstrumentation;
import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
import java.util.Arrays;
import java.util.List;
import net.bytebuddy.matcher.ElementMatcher;
Expand Down Expand Up @@ -57,7 +56,7 @@ public List<TypeInstrumentation> typeInstrumentations() {
}

@Override
public boolean defaultEnabled(ConfigProperties config) {
public boolean defaultEnabled() {
// TODO: replace this with an experimental flag
return false;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
import io.opentelemetry.javaagent.extension.instrumentation.internal.ExperimentalInstrumentationModule;
import io.opentelemetry.javaagent.extension.instrumentation.internal.injection.ClassInjector;
import io.opentelemetry.javaagent.extension.instrumentation.internal.injection.InjectionMode;
import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
import java.util.List;
import net.bytebuddy.matcher.ElementMatcher;

Expand Down Expand Up @@ -65,7 +64,7 @@ public List<TypeInstrumentation> typeInstrumentations() {
}

@Override
public boolean defaultEnabled(ConfigProperties config) {
public boolean defaultEnabled() {
// produces a lot of metrics that are already captured - e.g. JVM memory usage
return false;
}
Expand Down
Loading
Loading