Alternate strategy for pinning collector images#7586
Merged
Conversation
fe98a10 to
8327c81
Compare
jkwatson
reviewed
Aug 18, 2025
| 'helpers:pinGitHubActionDigestsToSemver', | ||
| 'customManagers:githubActionsVersions' | ||
| ], | ||
| ignorePaths: [], // overwrite default ignore which includes **/test/** |
Contributor
There was a problem hiding this comment.
for this particular rule, we only want to scan test paths, yes? Would it make renovate more efficient if we could encode that?
Member
Author
There was a problem hiding this comment.
it didn't seem like you could change the ignorePaths per custom manager
I don't think the efficiency is the problem, more about Renovate picking up false positives, which luckily didn't seem to be a problem for this repo (I tested in my fork)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7586 +/- ##
=========================================
Coverage 90.01% 90.01%
Complexity 7081 7081
=========================================
Files 803 803
Lines 21419 21419
Branches 2086 2086
=========================================
Hits 19280 19280
Misses 1477 1477
Partials 662 662 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
the-clam
pushed a commit
to the-clam/opentelemetry-java
that referenced
this pull request
Nov 6, 2025
Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pros:
Cons:
cc @zeitlinger