Do not attempt to enumerate or normalize entries from carrier#8474
Merged
jack-berg merged 3 commits intoJun 16, 2026
Conversation
Member
|
This is correct. Just the tests need to be updated 😉 |
Codecov Report❌ Patch coverage is
❌ Your project check has failed because the head coverage (78.24%) is below the target coverage (89.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #8474 +/- ##
=============================================
- Coverage 91.04% 78.54% -12.50%
- Complexity 7822 8474 +652
=============================================
Files 893 1008 +115
Lines 23721 28830 +5109
Branches 2364 3570 +1206
=============================================
+ Hits 21596 22645 +1049
- Misses 1407 5341 +3934
- Partials 718 844 +126 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jaydeluca
approved these changes
Jun 11, 2026
cijothomas
pushed a commit
to cijothomas/opentelemetry-specification
that referenced
this pull request
Jun 12, 2026
…etry#5144) Fixes open-telemetry#5143 Prototypes: - open-telemetry/opentelemetry-go-contrib#9112 - open-telemetry/opentelemetry-cpp#4141 - open-telemetry/opentelemetry-java#8474 - open-telemetry/opentelemetry-js#6774 - open-telemetry/opentelemetry-python#5289 - open-telemetry/opentelemetry-swift-core#83 ### Rationale The previous wording required environment variable carriers to normalize every key present in the carrier before matching a requested propagation key. This PR removes that requirement for two reasons: - **Efficiency**: extraction should not require reading every environment variable - **Determinism**: if multiple environment variable names normalize to the same key, selecting one is ambiguous and implementation-dependent. Instead, carriers normalize the key requested by the propagator and read only the corresponding normalized environment variable name. `Keys` similarly returns only environment variable names that are already normalized. This keeps injection behavior unchanged while making extraction predictable and avoiding unnecessary environment enumeration.
…pagation/EnvironmentSetter.java Co-authored-by: Jay DeLuca <jaydeluca4@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
open-telemetry/opentelemetry-specification#5144
cc @pellared - I think this is the intent of the spec PR