Skip to content

Allow google/protobuf 5#1983

Merged
bobstrecansky merged 1 commit into
open-telemetry:mainfrom
derrabus:patch-1
Jun 17, 2026
Merged

Allow google/protobuf 5#1983
bobstrecansky merged 1 commit into
open-telemetry:mainfrom
derrabus:patch-1

Conversation

@derrabus

Copy link
Copy Markdown
Contributor

#1904 enabled the usage of google/protobuf 5, but apparently the composer.json file of the subtree split was forgotten. Because of that, downstream projects can't use open-telemetry/gen-otlp-protobuf together with google/protobuf 5.

@derrabus derrabus requested a review from a team as a code owner June 11, 2026 12:03
@linux-foundation-easycla

linux-foundation-easycla Bot commented Jun 11, 2026

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: derrabus / name: Alexander M. Turek (9000d0f)

@codecov

codecov Bot commented Jun 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.88%. Comparing base (2f1c57f) to head (9000d0f).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1983      +/-   ##
============================================
+ Coverage     67.87%   67.88%   +0.01%     
  Complexity     3046     3046              
============================================
  Files           459      459              
  Lines          8891     8891              
============================================
+ Hits           6035     6036       +1     
+ Misses         2856     2855       -1     
Flag Coverage Δ
8.1 67.58% <ø> (+0.01%) ⬆️
8.2 67.73% <ø> (-0.08%) ⬇️
8.3 67.81% <ø> (ø)
8.4 67.83% <ø> (+0.06%) ⬆️
8.5 67.84% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 6 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f1c57f...9000d0f. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ChrisLightfootWild ChrisLightfootWild left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @derrabus

@ChrisLightfootWild ChrisLightfootWild requested a review from a team June 11, 2026 13:04
@bobstrecansky bobstrecansky merged commit 056b939 into open-telemetry:main Jun 17, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants