Skip to content

pyramid: use test_base to fetch metrics for assertions #4129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xrmx merged 4 commits into from
Jan 23, 2026
Merged

pyramid: use test_base to fetch metrics for assertions #4129

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9c71312
pyramid: use test_base to fetch metrics for assertions
anuraaga Jan 23, 2026
559ff35
Fix assertion
anuraaga Jan 23, 2026
a5b597b
Update instrumentation/opentelemetry-instrumentation-pyramid/tests/te…
xrmx Jan 23, 2026
5fa2999
Merge branch 'main' into pyramid-metrics
xrmx Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 14 additions & 20 deletions instrumentation/opentelemetry-instrumentation-pyramid/tests/test_automatic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,28 +223,22 @@ def test_pyramid_metric(self):
self.client.get("/hello/756")
self.client.get("/hello/756")
self.client.get("/hello/756")
metrics_list = self.memory_metrics_reader.get_metrics_data()
metrics = self.get_sorted_metrics()
number_data_point_seen = False
histogram_data_point_seen = False
self.assertTrue(len(metrics_list.resource_metrics) == 1)
for resource_metric in metrics_list.resource_metrics:
self.assertTrue(len(resource_metric.scope_metrics) == 1)
for scope_metric in resource_metric.scope_metrics:
self.assertTrue(len(scope_metric.metrics) == 2)
for metric in scope_metric.metrics:
self.assertIn(metric.name, _expected_metric_names)
data_points = list(metric.data.data_points)
self.assertEqual(len(data_points), 1)
for point in data_points:
if isinstance(point, HistogramDataPoint):
self.assertEqual(point.count, 3)
histogram_data_point_seen = True
if isinstance(point, NumberDataPoint):
number_data_point_seen = True
for attr in point.attributes:
self.assertIn(
attr, _recommended_attrs[metric.name]
)
self.assertEqual(len(metrics), 2)
for metric in metrics:
self.assertIn(metric.name, _expected_metric_names)
data_points = list(metric.data.data_points)
self.assertEqual(len(data_points), 1)
for point in data_points:
if isinstance(point, HistogramDataPoint):
self.assertEqual(point.count, 3)
histogram_data_point_seen = True
if isinstance(point, NumberDataPoint):
number_data_point_seen = True
for attr in point.attributes:
self.assertIn(attr, _recommended_attrs[metric.name])
self.assertTrue(number_data_point_seen and histogram_data_point_seen)

def test_basic_metric_success(self):
Expand Down