Fix pylint false positives for ThreadPoolExecutor#4244
Open
srikaaviya wants to merge 1 commit intoopen-telemetry:mainfrom
Open
Fix pylint false positives for ThreadPoolExecutor#4244srikaaviya wants to merge 1 commit intoopen-telemetry:mainfrom
srikaaviya wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
3d58728 to
bdd972d
Compare
xrmx
requested changes
Feb 24, 2026
Contributor
xrmx
left a comment
There was a problem hiding this comment.
I don't think this is the right way to fix this. We should fix all the issue we have with a newer pylint version and then remove the comments.
DylanRussell
approved these changes
Feb 24, 2026
|
|
||
| # from concurrent.futures import ( # pylint: disable=no-name-in-module; TODO #4199 | ||
| # ThreadPoolExecutor, | ||
| # ) |
Contributor
There was a problem hiding this comment.
do we need this commented out ? can we just remove it ? here and everywhere else ?
|
I agree with @xrmx in that we should bump the pylint version instead of using the fully qualified names. |
bdd972d to
59e2617
Compare
Author
|
@xrmx @DylanRussell Thanks for the feedback! I've reverted the import workarounds and bumped pylint to 4.0.5 in dev-requirements.txt which resolves the false positives natively on Python 3.14. I also removed the comments and deprecated suggestion-mode option from .pylintrc which was dropped in Pylint 4. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the
concurrent.futuresimport style in three files to bypass a knownno-name-in-modulepylint parsing bug introduced when adding Python 3.14 support.By using
import concurrent.futuresand fully qualifyingconcurrent.futures.ThreadPoolExecutorandconcurrent.futures.Future, we cleanly resolve the false positive without needing any# pylint: disablecomments or global config overrides.Fixes #4199
Type of change
How Has This Been Tested?
The official tox linting suites passed successfully:
Does This PR Require a Core Repo Change?
No.
Checklist: