[system_metrics] Update system.disk.time to system.disk.operation.time #4248
[system_metrics] Update system.disk.time to system.disk.operation.time #4248srikaaviya wants to merge 2 commits intoopen-telemetry:mainfrom
Conversation
|
|
||
| # Translation layer for handling the changed arg position of "ex" in Falcon > 2 vs | ||
| # Falcon < 2 | ||
| def _handle_exception(self, *args): |
There was a problem hiding this comment.
I think this change snuck in from the other PR. Could we trim this PR down so it's only for the system-metrics?
There was a problem hiding this comment.
@tammy-baylis-swi Sorry for the PR mix. I've pushed a cleaned up branch that only contains the system metrics changes.
ceab60b to
0d9c9c0
Compare
|
Thanks @srikaaviya that's better! Please could you also add a line to Changelog. |
Done! Just pushed a changelog entry. |
tammy-baylis-swi
left a comment
There was a problem hiding this comment.
This lgtm! The Maintainers will also look. The docker-test fails aren't related and are happening in other PRs.
I think technically this is a breaking change but not worth a special transition/opt-in.
Thanks for the review! |
Description
This PR resolves a pending
FIXMEin theopentelemetry-instrumentation-system-metricsmodule by updating the deprecatedsystem.disk.timesemantic convention to the current standardsystem.disk.operation.time.system.disk.timeinternal configurations and metric generation callbacks to the newsystem.disk.operation.timenomenclature.Type of change
How Has This Been Tested?
Ran the full instrumentation tox testing suite and linter, confirming both the runtime assertions and the style compliance passed perfectly on the updated module.
tox -e py311-instrumentation-system-metricstox -e lint-instrumentation-system-metricsDoes This PR Require a Core Repo Change?
Checklist: