Skip to content

Comments

[system_metrics] Update system.disk.time to system.disk.operation.time #4248

Open
srikaaviya wants to merge 2 commits intoopen-telemetry:mainfrom
srikaaviya:fix-system-disk-operation-time
Open

[system_metrics] Update system.disk.time to system.disk.operation.time #4248
srikaaviya wants to merge 2 commits intoopen-telemetry:mainfrom
srikaaviya:fix-system-disk-operation-time

Conversation

@srikaaviya
Copy link

Description

This PR resolves a pending FIXME in the opentelemetry-instrumentation-system-metrics module by updating the deprecated system.disk.time semantic convention to the current standard system.disk.operation.time.

  • Migrated system.disk.time internal configurations and metric generation callbacks to the new system.disk.operation.time nomenclature.
  • Updated local unit test [test_system_metrics.py]

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Ran the full instrumentation tox testing suite and linter, confirming both the runtime assertions and the style compliance passed perfectly on the updated module.

  • tox -e py311-instrumentation-system-metrics
  • tox -e lint-instrumentation-system-metrics

Does This PR Require a Core Repo Change?

  • No.

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been updated


# Translation layer for handling the changed arg position of "ex" in Falcon > 2 vs
# Falcon < 2
def _handle_exception(self, *args):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change snuck in from the other PR. Could we trim this PR down so it's only for the system-metrics?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tammy-baylis-swi Sorry for the PR mix. I've pushed a cleaned up branch that only contains the system metrics changes.

@srikaaviya srikaaviya force-pushed the fix-system-disk-operation-time branch from ceab60b to 0d9c9c0 Compare February 23, 2026 22:09
@tammy-baylis-swi
Copy link
Contributor

Thanks @srikaaviya that's better! Please could you also add a line to Changelog.

@srikaaviya
Copy link
Author

srikaaviya commented Feb 24, 2026

Thanks @srikaaviya that's better! Please could you also add a line to Changelog.

Done! Just pushed a changelog entry.

Copy link
Contributor

@tammy-baylis-swi tammy-baylis-swi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lgtm! The Maintainers will also look. The docker-test fails aren't related and are happening in other PRs.

I think technically this is a breaking change but not worth a special transition/opt-in.

@srikaaviya
Copy link
Author

This lgtm! The Maintainers will also look. The docker-test fails aren't related and are happening in other PRs.

I think technically this is a breaking change but not worth a special transition/opt-in.

Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Ready for review

Development

Successfully merging this pull request may close these issues.

4 participants