Skip to content

Comments

Fix dead link to benchmarks documentation#4255

Closed
thakoreh wants to merge 2 commits intoopen-telemetry:mainfrom
thakoreh:fix-dead-benchmarks-link
Closed

Fix dead link to benchmarks documentation#4255
thakoreh wants to merge 2 commits intoopen-telemetry:mainfrom
thakoreh:fix-dead-benchmarks-link

Conversation

@thakoreh
Copy link

Description

Fixes issue #4163 - Dead link on /performance/benchmarks.html

The link to https://open-telemetry.github.io/opentelemetry-python-contrib/benchmarks/index.html returns 404.

Changes

  • Removed the dead link
  • Added information about where to find benchmark tests locally
  • Added instructions for running benchmarks locally with pytest-benchmark

Testing

No code changes, only documentation updates.

Add documentation explaining how to use the OTEL_SEMCONV_STABILITY_OPT_IN
environment variable to control semantic convention stability opt-in for
HTTP instrumentations.

Fixes: open-telemetry#4202
The link to open-telemetry.github.io is 404. Updated documentation to
point to local benchmark directories and provide instructions for running
benchmarks locally.

Fixes: open-telemetry#4163
@thakoreh thakoreh requested a review from a team as a code owner February 24, 2026 14:19
@xrmx xrmx moved this to Easy to review / merge / close in @xrmx's Python PR digest Feb 24, 2026
@xrmx xrmx moved this from Easy to review / merge / close to Reviewed PRs that need fixes in @xrmx's Python PR digest Feb 24, 2026
Copy link
Contributor

@xrmx xrmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you have some unrelated changes in this PR.

Comment on lines +11 to +18
Run benchmarks using pytest with the ``--benchmark-only`` flag after installing ``pytest-benchmark``:

.. code-block:: sh
pip install pytest-benchmark
pytest --benchmark-only path/to/benchmarks/
Note: Pre-built benchmark results are not currently hosted online.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we look at tox.ini, we have specific tox environment for every benchmark, so it's tox -e benchmark-<whatever>

@xrmx
Copy link
Contributor

xrmx commented Feb 24, 2026

Also we have already #4238 open, so closing.

@xrmx xrmx closed this Feb 24, 2026
@github-project-automation github-project-automation bot moved this from Reviewed PRs that need fixes to Done in @xrmx's Python PR digest Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants