-
Notifications
You must be signed in to change notification settings - Fork 28
fix(openai): expose headers on streaming with_raw_response wrapper #147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
YuxiangJiangCT
wants to merge
3
commits into
open-telemetry:main
Choose a base branch
from
YuxiangJiangCT:fix/openai-chat-stream-headers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
d7ccaee
fix(openai): expose headers on streaming with_raw_response wrapper
YuxiangJiangCT 4d60e1c
Merge branch 'main' into fix/openai-chat-stream-headers
eternalcuriouslearner 2a98bec
Merge branch 'main' into fix/openai-chat-stream-headers
eternalcuriouslearner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
1 change: 1 addition & 0 deletions
1
instrumentation/opentelemetry-instrumentation-genai-openai/.changelog/147.fixed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| expose response headers on the streaming with_raw_response chat wrapper |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1394,3 +1394,33 @@ async def async_chat_completion_multiple_tools_streaming( | |
| assert_message_in_logs( | ||
| logs[2], "gen_ai.choice", choice_event, spans[0] | ||
| ) | ||
|
|
||
|
|
||
| @pytest.mark.asyncio() | ||
| async def test_chat_completion_with_raw_response_streaming_exposes_headers( | ||
|
Comment on lines
+1399
to
+1400
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Kept @pytest.mark.asyncio() with parens to match the existing async tests in this file - changing only this one would be inconsistent. Happy to switch all of them in a separate cleanup if preferred. |
||
| span_exporter, async_openai_client, instrument_with_content, vcr | ||
| ): | ||
| """Regression test for #46 (async path). | ||
|
|
||
| Accessing ``.headers`` on the async streaming ``with_raw_response`` | ||
| wrapper used to raise ``AttributeError`` because the headers were | ||
| discarded when the response was parsed into the underlying stream. | ||
| """ | ||
| with vcr.use_cassette( | ||
| "test_chat_completion_with_raw_response_streaming.yaml" | ||
| ): | ||
| raw_response = await async_openai_client.chat.completions.with_raw_response.create( | ||
| messages=USER_ONLY_PROMPT, | ||
| model=DEFAULT_MODEL, | ||
| stream=True, | ||
| stream_options={"include_usage": True}, | ||
| ) | ||
|
|
||
| assert raw_response.headers is not None | ||
| assert "text/event-stream" in raw_response.headers.get("content-type", "") | ||
|
|
||
| response = raw_response.parse() | ||
| assert [chunk async for chunk in response] | ||
|
|
||
| spans = span_exporter.get_finished_spans() | ||
| assert len(spans) == 1 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.