Don't call set attribute twice for the same key and make start attributes unsettable#150
Draft
lmolkova wants to merge 2 commits into
Draft
Don't call set attribute twice for the same key and make start attributes unsettable#150lmolkova wants to merge 2 commits into
lmolkova wants to merge 2 commits into
Conversation
lmolkova
commented
Jun 18, 2026
| ) | ||
| invocation.stop() | ||
|
|
||
| assert invocation.request_model == "text-embedding-3-small" |
Member
Author
There was a problem hiding this comment.
attributes validated below
lmolkova
commented
Jun 18, 2026
|
|
||
| def _get_base_attributes(self) -> dict[str, Any]: | ||
| @property | ||
| def agent_name(self) -> str | None: |
Member
Author
There was a problem hiding this comment.
this one is used by langchain, convert to read-only property
lmolkova
changed the title
| self.request_model = request_model | ||
| self.server_address = server_address | ||
| self.server_port = server_port | ||
| self._provider: str = provider |
Contributor
There was a problem hiding this comment.
so _ means don't directly set this, instead pass it in on initialization.. Is that enforced somehow or is it just a convention ? Does it cause a lint error at least ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.