fix: Drop JAEGER related environment variables#4931
Open
mateenali66 wants to merge 1 commit intoopen-telemetry:mainfrom
Open
fix: Drop JAEGER related environment variables#4931mateenali66 wants to merge 1 commit intoopen-telemetry:mainfrom
mateenali66 wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
|
|
…#4918) The Jaeger exporter was removed in v1.22.0 (2023-12-15), but the OTEL_EXPORTER_JAEGER_* environment variables remained in the SDK environment variables module unused. This removes all nine of them: OTEL_EXPORTER_JAEGER_AGENT_HOST, OTEL_EXPORTER_JAEGER_AGENT_PORT, OTEL_EXPORTER_JAEGER_ENDPOINT, OTEL_EXPORTER_JAEGER_USER, OTEL_EXPORTER_JAEGER_PASSWORD, OTEL_EXPORTER_JAEGER_TIMEOUT, OTEL_EXPORTER_JAEGER_CERTIFICATE, OTEL_EXPORTER_JAEGER_AGENT_SPLIT_OVERSIZED_BATCHES, and OTEL_EXPORTER_JAEGER_GRPC_INSECURE.
mateenali66
force-pushed
the
oss-contrib/4918-drop-jaeger-related-environment-variable
branch
from
1a57191 to
5c20ec1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #4918.
Done. Here's a summary of what was changed and why:
Summary
Issue: OTEL_EXPORTER_JAEGER_* environment variables were still defined in the SDK despite the Jaeger exporter being removed in v1.22.0 (December 2023).
Changes made:
opentelemetry-sdk/src/opentelemetry/sdk/environment_variables/__init__.py— Removed 9 unused Jaeger environment variable definitions (71 lines total):OTEL_EXPORTER_JAEGER_AGENT_HOSTOTEL_EXPORTER_JAEGER_AGENT_PORTChanges