feat: add deepcopy implementation for BoundedAttributes#4934
Open
herin049 wants to merge 2 commits intoopen-telemetry:mainfrom
Open
feat: add deepcopy implementation for BoundedAttributes#4934herin049 wants to merge 2 commits intoopen-telemetry:mainfrom
herin049 wants to merge 2 commits intoopen-telemetry:mainfrom
Conversation
pmcollins
reviewed
Feb 25, 2026
Member
pmcollins
left a comment
pmcollins
left a comment
There was a problem hiding this comment.
Looks like if you create a span via tracer.start_as_current_span(...), the _events member is set to a BoundedList, which apparently also has a lock that will prevent a deep copy.
| def __deepcopy__(self, memo: dict) -> "BoundedAttributes": | ||
| with self._lock: | ||
| attributes = copy.deepcopy(self._dict, memo) | ||
| copy_ = BoundedAttributes( |
Member
There was a problem hiding this comment.
There's also a dropped field in BoundedAttributes that we may want to copy (looks like this value is actually exported in _encode_links), but it would have to be set via direct field access since there's no constructor arg for it.
tammy-baylis-swi
moved this to Reviewed PRs that need fixes
in @xrmx's Python PR digest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a custom
__deepcopy__implementation forBoundedAttributes.Fixes #4928
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Does This PR Require a Contrib Repo Change?
Checklist: