fix(sdk): improve force flush logic#5179
Open
grvmishra788 wants to merge 3 commits intoopen-telemetry:mainfrom
Open
fix(sdk): improve force flush logic#5179grvmishra788 wants to merge 3 commits intoopen-telemetry:mainfrom
grvmishra788 wants to merge 3 commits intoopen-telemetry:mainfrom
Conversation
Author
|
Hi @alexmojaki! Could you please review this one? TIA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4631
Before:
SynchronousMultiSpanProcessor.force_flushandSynchronousMultiLogRecordProcessor.force_flushusedif not sp.force_flush(...): return False, which stopped iterating through processors as soon as any one returned a falsy value. This meant that a processor returningNonewould cause all subsequent processors to be silently skipped. The concurrent variants had the same truthiness check on results, incorrectly treatingNoneas failure.After: All multi-processor
force_flushimplementations now:is Falseinstead ofnot resultto distinguish between an explicitFalse(timeout exceeded) andNone(not implemented / nothing to flush).SpanProcessor.force_flushreturnsTrueby default instead of implicitly returningNone.Type of change
How Has This Been Tested?
Does This PR Require a Contrib Repo Change?
Checklist: