Skip to content

Remove Events API/SDK#5293

Open
rads-1996 wants to merge 8 commits into
open-telemetry:mainfrom
rads-1996:remove-events
Open

Remove Events API/SDK#5293
rads-1996 wants to merge 8 commits into
open-telemetry:mainfrom
rads-1996:remove-events

Conversation

@rads-1996

@rads-1996 rads-1996 commented Jun 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Address issue #4655

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Unit tests

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@rads-1996 rads-1996 requested a review from a team as a code owner June 11, 2026 17:34
@JacksonWeber

JacksonWeber commented Jun 14, 2026

Copy link
Copy Markdown
Contributor

You may want to decorate the no-op shims with @deprecated(...) just so external users importing them will get a warning.

@rads-1996

rads-1996 commented Jun 15, 2026

Copy link
Copy Markdown
Contributor Author

You may want to decorate the no-op shims with @deprecated(...) just so external users importing them will get a warning.

These were deprecated a few versions back. We need to now remove them. Hence, we are not decorating them. Is that what you were referring to?

@JacksonWeber

JacksonWeber commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

You may want to decorate the no-op shims with @deprecated(...) just so external users importing them will get a warning.

These were deprecated a few versions back. We need to now remove them. Hence, we are not decorating them. Is that what you were referring to?

My bad, looks like they're just test functions, nothing part of the public api. LGTM

@rads-1996 rads-1996 force-pushed the remove-events branch 3 times, most recently from ce77b58 to d157ebe Compare June 15, 2026 23:09
DylanRussell
DylanRussell approved these changes Jun 16, 2026
View reviewed changes
Comment thread .changelog/5293.removed Outdated
@emdneto emdneto moved this to Approved PRs in Python PR digest Jun 16, 2026
@rads-1996 rads-1996 force-pushed the remove-events branch 2 times, most recently from 1ecaaef to 832323d Compare June 17, 2026 16:16
@rads-1996 rads-1996 force-pushed the remove-events branch 2 times, most recently from 342f4b7 to 0e75aa3 Compare June 18, 2026 16:03
@carlosalberto

carlosalberto commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

(Symbolic approval - right direction to align the implementation with the Specification)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carlosalberto carlosalberto carlosalberto approved these changes

@DylanRussell DylanRussell DylanRussell approved these changes

@emdneto emdneto emdneto approved these changes

@hectorhdzg hectorhdzg hectorhdzg approved these changes

+1 more reviewer

@JacksonWeber JacksonWeber JacksonWeber approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

Python PR digest
Status: Approved PRs

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@rads-1996 @JacksonWeber @carlosalberto @DylanRussell @emdneto @hectorhdzg