Update json and proto encoder to always accept None type, cleanup code / tests a little bit#5305
Merged
xrmx merged 11 commits intoJun 18, 2026
Conversation
herin049
approved these changes
Jun 16, 2026
Contributor
|
LGTM! |
xrmx
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is a precursor to updating the SDK to use
ExtendedAttributeseverywhere: #5266.. I'm trying to make that PR a bit smaller / easier to review..Update the encoder to always accept null as that is a valid value according to the spec, and encode it as an empty
AnyValue.. this is in-line with the spec: open-telemetry/opentelemetry-specification#4392 - previously we would do this for Arrays but not Maps and not when None is encoded as a primitive..Update
_encode_attributesto accept_ExtendedAttribuesvalue type instead of the oldAttributeValue.Cleanup the code and tests a little bit.
Type of change
How Has This Been Tested?
Unit tests
Does This PR Require a Contrib Repo Change?
Checklist: