Remove stale 2024 benchmark entries stuck on gh-pages#5317
Open
mwimpelberg28 wants to merge 2 commits into
Open
Remove stale 2024 benchmark entries stuck on gh-pages#5317mwimpelberg28 wants to merge 2 commits into
mwimpelberg28 wants to merge 2 commits into
Conversation
|
|
mwimpelberg28
force-pushed
the
gh-pages-cleanup
branch
from
a83aa0f to
ce722e2
Compare
The benchmark workflow's 'name' was changed from per-Python-version (e.g. 'OpenTelemetry Python SDK Benchmarks - Python 3.11 - SDK') to a single 'OpenTelemetry Python SDK Benchmarks'. github-action-benchmark keys data by name and never prunes orphaned entries, leaving two groups frozen in 2024 that show as stale charts on https://opentelemetry.io/docs/languages/python/benchmarks/ Removes those two orphaned entries; the active entry is unchanged. Fixes open-telemetry#5006
mwimpelberg28
force-pushed
the
gh-pages-cleanup
branch
from
912f4fb to
23d2003
Compare
xrmx
approved these changes
Jun 18, 2026
xrmx
moved this from Approved PRs
to Easy to review / merge / close
in Python PR digest
emdneto
approved these changes
Jun 18, 2026
github-project-automation
Bot
moved this from Easy to review / merge / close
to Approved PRs
in Python PR digest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5006
The benchmarks page shows several charts frozen in 2024. The cause: the benchmark workflow's
namewas changed from a per-Python-version label (e.g.OpenTelemetry Python SDK Benchmarks - Python 3.11 - SDK) to a singleOpenTelemetry Python SDK Benchmarks.github-action-benchmarkkeys data bynameand never prunes orphaned entries (see github-action-benchmark#299), so two old entry groups were left stuck:...Benchmarks - Python 3.11 - SDK...Benchmarks - Python 3.12 - SDKOpenTelemetry Python SDK Benchmarks(active)This PR removes the two orphaned entries from
benchmarks/data.js. The change is a pure deletion — the active entry is byte-for-byte unchanged, and the resulting file is valid (window.BENCHMARK_DATAstill parses, singleentrieskey).index.htmlreads entries dynamically, so no other change is needed. The current workflow uses one stable name, so this won't recur.🤖 Assisted by Claude Code
Co-Authored-By: Matthew Wimpelberg 120263653+mwimpelberg28@users.noreply.github.com