opentelemetry-sdk: expose SynchronousMultiLogRecordProcessor and ConcurrentMultiLogRecordProcessor publicly#5327
Open
mwimpelberg28 wants to merge 7 commits into
Conversation
) The weaver binary's gRPC C core crashes with SIGABRT (exit code -6) on PyPy due to an epoll_wait EBADF error in ev_epoll1_linux.cc. This is a known incompatibility between gRPC's epoll1 event engine and PyPy subprocesses that cannot be fixed from the Python side. Skip both weaver test classes on PyPy, consistent with how other gRPC-dependent tests are excluded from PyPy in this repo. Assisted-by: Claude Sonnet 4.6
…#5176) Weaver switched from gRPC C core to tonic (pure Rust) for its OTLP server, so the epoll_wait EBADF crash that caused test flakiness on PyPy no longer occurs. Verified by running the full weaver test suite on PyPy 3.10 with grpcio compiled from source. Remove the `platform_python_implementation != 'PyPy'` exclusions from test-requirements.txt and the PyPy skip decorators added as a workaround, so the weaver integration tests now run on PyPy as well. Assisted-by: Claude Sonnet 4.6
grpcio has no PyPy wheel and the gRPC C core fails to build from source with MSVC on Windows PyPy, so the previous "remove all PyPy exclusions" change broke the Windows PyPy job. Gate the grpc deps off on PyPy+Windows only; the weaver tests skip there via the existing _HAS_GRPC guard while still running on Linux PyPy. Assisted-by: Claude Opus 4.8 (1M context)
…urrentMultiLogRecordProcessor publicly Fixes open-telemetry#5312 Assisted-by: Claude Sonnet 4.6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5312
SynchronousMultiLogRecordProcessorandConcurrentMultiLogRecordProcessorfrom the publicopentelemetry.sdk._logsnamespace, mirroring howSynchronousMultiSpanProcessorandConcurrentMultiSpanProcessorare already public inopentelemetry.sdk.traceTest plan
uv run tox -e py312-test-opentelemetry-sdk -- opentelemetry-sdk/tests/logs/test_multi_log_processor.py🤖 Generated with Claude Code