feat: Add in generation of event names#2132
Conversation
kaylareopelle
left a comment
kaylareopelle
left a comment
There was a problem hiding this comment.
I think this looks good, @thompson-tomo. Thanks for opening the PR.
| file_name: "incubating/{{ctx.root_namespace | snake_case}}/metrics.rb" | ||
| params: | ||
| incubating: true | ||
| - pattern: events.j2 |
There was a problem hiding this comment.
Are all events incubating at this time? Do we need to add any to the stable group?
There was a problem hiding this comment.
Yes I was going to add stable but first want to resolve/confirm namespacing situation.
| incubating: true | ||
| - pattern: events.j2 | ||
| application_mode: each | ||
| filter: '.groups | map(select(.type == "event")) | group_by(.name | split(".") | .[0]) | map({id: .[0].id | split(".") | .[1], groups: .})' |
There was a problem hiding this comment.
I'm surprised weaver doesn't have a semconv_grouped_events filter. I checked the same spot where semconv_grouped_metrics is defined and didn't see anything. This seems to capture the events well.
There was a problem hiding this comment.
It is in the process of being added as it was in the docs but didnt work as wasn't implemented.
|
👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the |
|
Awaiting on guidance on how to address potential naming conflicts arising from not splitting based on type. |
2 participants
No description provided.