test: Increased tests of otlp common#2159
Open
thompson-tomo wants to merge 9 commits into
Open
Conversation
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
thompson-tomo
requested review from
ahayworth,
arielvalentin,
dazuma,
ericmustin,
fbogsany,
kaylareopelle,
mwear,
plantfansam,
robbkidd,
robertlaurin and
xuan-cao-swi
as code owners
Add a test for encoding errors in span attributes.
mwear
reviewed
Jun 12, 2026
| end | ||
| end | ||
|
|
||
| describe 'private methods' do |
Member
There was a problem hiding this comment.
In general, I would prefer private methods be tested indirectly via the public API. This allows us to make internal refactors without having the changes cascade into tests. It's not a hard rule, and there are sometimes reasonable exceptions, but I'm wondering if these are necessary?
Contributor
Author
There was a problem hiding this comment.
I also agree. Note this pr is purely a split of #2075 to decouple feature from additional test cases
Contributor
Author
There was a problem hiding this comment.
I actually haven't written anything, this is just a split of @arjun-rajappa work.
I can however reduce the scope in this pr.
simi
approved these changes
Jun 14, 2026
mwear
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced new tests to improve coverage. Has been split out of #2075 to decouple changes.
Code coverage prior to change:
After change: