Prometheus exporter: Stabilize section 'Content Negotiation'#5136
Open
ArthurSens wants to merge 2 commits into
Open
Prometheus exporter: Stabilize section 'Content Negotiation'#5136ArthurSens wants to merge 2 commits into
ArthurSens wants to merge 2 commits into
Conversation
Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
krajorama
reviewed
Jun 8, 2026
| **Status**: [Development](../../document-status.md) | ||
| **Status**: [Stable](../../document-status.md) | ||
|
|
||
| A Prometheus Exporter MUST support content negotiation to allow clients to request |
Member
There was a problem hiding this comment.
Actually after reading #5062 , it seems like we should specify what to do if no Accept header is presented by the client to make it explicit. Fall back to text/plain version=0.0.4 and underscores translation. Text format 0.0.4 doesn't support utf-8.
Member
|
Also there's a dependency to #5134 as that modifies the content negotiation part. |
bogdandrutu
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4991
Changes
Stabilize the section
Content Negotiationin the Prometheus exporter spec.While reviewing the SDK implementation, I found these:
Fully compliant
Almost compliant
qweights and doesn't support protobuf.Acceptheaders, supportstext/plainandapplication/openmetrics, respectsqweights, and falls back to Prometheus text 0.0.4. It doesn't support.allow-utf-8is treated the same way asunderscores, they are always escaped.Non compliant
CHANGELOG.mdfile updated for non-trivial changes[chore]in the PR title to skip the changelog check