Add base to root module to enable ./gradlew clean#505
Merged
Conversation
trask
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you've got the project checked out locally, and try to run the commands from CONTRIBUTING.md after a semconv version update, then gradle uses the existing semconv download from build/ instead of downloading a new one:
There is probably more work to do with properly specifying gradle task input/outputs such that when
var semanticConventionsVersion = 1.42.0and onlybuild/semantic-conventions-1.41.1exists, thedownloadSemanticConventionstask knows it needs to downloadbuild/semantic-conventions-1.42.0. But the simplest / immediate fix is to make sure the clean task from./gradlew clean generateSemanticConventions --console=plainactually deletesbuild/and everything in it.