Guard Open64-specific flags in libm for BUILD_COMPILER=GNU#47
Open
noafroboy wants to merge 1 commit intoopen64-compiler:developfrom
Open
Guard Open64-specific flags in libm for BUILD_COMPILER=GNU#47noafroboy wants to merge 1 commit intoopen64-compiler:developfrom
noafroboy wants to merge 1 commit intoopen64-compiler:developfrom
Conversation
When building libm with BUILD_COMPILER=GNU (e.g., for bootstrapping or cross-compilation), the Open64-specific flags -OPT:alias=restrict, -TENV:X=2, and -WOPT:cse_fcmp cause GCC to fail with "unrecognized command line option". Guard these flags behind ifneq ($(BUILD_COMPILER), GNU) so the build succeeds with either compiler. The CCFVLOG and CCFVSQRT variables are still set correctly in both paths. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-OPT:alias=restrict:alias=unnamed,-TENV:X=2, and-WOPT:cse_fcmpflags behindifneq ($(BUILD_COMPILER), GNU)inosprey/libm/Makefile.gbaseMotivation
When building libm with
BUILD_COMPILER=GNU(for bootstrapping or when the Open64 compiler is not yet available), these Open64-specific flags cause GCC to fail:The fix only affects the
BUILD_COMPILER=GNUpath; the Open64 (SELF/OSP/PSC) build path is unchanged.Test plan
BUILD_COMPILER=GNU— no unrecognized option errorsBUILD_COMPILER=OSP— flags still applied as before🤖 Generated with Claude Code