Fix whirl2f.so hardcoded maccom.so dependency#54
Open
noafroboy wants to merge 1 commit intoopen64-compiler:developfrom
Open
Fix whirl2f.so hardcoded maccom.so dependency#54noafroboy wants to merge 1 commit intoopen64-compiler:developfrom
noafroboy wants to merge 1 commit intoopen64-compiler:developfrom
Conversation
whirl2f's Makefile hardcoded 'maccom.so' as its backend DSO dependency, but maccom.so is only the correct name when BUILD_PRODUCT=MASTIFF. For the standard open-source build, the backend is named 'be.so'. This caused a race condition in parallel builds: whirl2f.so would try to link against a maccom.so symlink pointing to a nonexistent file in the be directory, since 'be.so' (not 'maccom.so') is what gets built. Fix by using $(BE_SO) — which resolves to 'be.so' or 'maccom.so' depending on BUILD_PRODUCT — matching what whirl2c already does. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maccom.soreferences inosprey/be/whirl2f/Makefile.gbasewith$(BE_SO)Motivation
The xcalscan merge (commit 12cc654) replaced
be.sowith hardcodedmaccom.soin whirl2f's Makefile.maccom.sois only the correct backend DSO name whenBUILD_PRODUCT=MASTIFF. For the standard open-source build (BUILD_PRODUCT=OPEN64), the backend isbe.so.This causes whirl2f.so to link against a
maccom.sosymlink pointing to a nonexistent file, since onlybe.sogets built.whirl2cin the same directory already correctly uses$(BE_SO).Changes
osprey/be/whirl2f/Makefile.gbase: Replace allmaccom.soreferences with$(BE_SO), matching the pattern used bywhirl2cTest plan
make buildwith defaultBUILD_PRODUCT=OPEN64— whirl2f.so links againstbe.so🤖 Generated with Claude Code