Remove stale x86_64 to i686 downgrade in configure#57
Open
noafroboy wants to merge 1 commit intoopen64-compiler:developfrom
Open
Remove stale x86_64 to i686 downgrade in configure#57noafroboy wants to merge 1 commit intoopen64-compiler:developfrom
noafroboy wants to merge 1 commit intoopen64-compiler:developfrom
Conversation
The configure script contained a workaround that silently rewrote host_cpu and target_cpu from x86_64 to i686 when --host/--target were not explicitly specified. This caused a 32-bit compiler to be built on 64-bit hosts by default. The comment said "There are known bugs when building the compiler in 64 bit mode on x86" — these bugs have long been fixed, and the compiler builds and runs correctly as a native 64-bit binary. Without this workaround, ./configure on an x86_64 host correctly detects the 64-bit platform and builds a 64-bit compiler. Users who need a 32-bit compiler can still pass --host=i686-linux-gnu. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
configure.ac(and generatedconfigure) that silently rewrotehost_cpuandtarget_cpufromx86_64toi686when--host/--targetwere not explicitly passed./configureon a 64-bit host to silently build a 32-bit compilerContext
The removed code had the comment:
These bugs have long been fixed. The compiler builds and runs correctly as a native 64-bit binary (verified with full end-to-end build + runtime library compilation on x86_64).
Without this workaround,
./configureon an x86_64 host correctly detects the platform and builds a 64-bit compiler. Users who need a 32-bit compiler can still pass--host=i686-linux-gnu --target=i686-linux-gnu.Test plan
./configure && make buildon x86_64 Linux without--host/--targetflagsfile osprey/targdir/driver/driver./configure --host=i686-linux-gnu --target=i686-linux-gnustill produces a 32-bit build🤖 Generated with Claude Code