Merged
Conversation
* docs: add Internet Computer (ICP) integration to README - Add InternetComputer method with ICP, ckBTC, ckETH, ckUSDC, ckUSDT assets to transferAmounts example - Add ICP transaction details JSON example (ICRC-2 approve flow) - Add Internet Computer section in Step 4 with both payment flows: - Option A: ICRC-2 Approve (recommended) - approve + sender parameter - Option B: Direct Transfer (TxId) - broadcast + tx parameter - Add sender query parameter to Important box * fix: correct ICP URI format and add asset parameter - URI schema: icp: → internetComputer:, amount as decimal, address after schema - Add &asset=ICP to all ICP example URLs (required for multi-asset methods) - Update Option A instructions to match new URI format Addresses review feedback from @bernd2022 * fix: typo 'prove' → 'proof', add asset parameter to docs - Fix typo: 'transaction prove' → 'transaction proof' - Add 'asset' to the Important query parameters list (required for ICP) * fix: correct ICP URI scheme from 'internetComputer:' to 'icp:' per API implementation --------- Co-authored-by: Nanobot <nanobot@opencryptopay.io> Co-authored-by: max-tech-bot <max-tech-bot@users.noreply.github.com>
TaprootFreak
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic Release PR
This PR was automatically created after changes were pushed to develop.
Commits: 1 new commit(s)
Checklist