1680: Improve error when exporting through an account_link#1846
Merged
kkoehn merged 4 commits intoJul 7, 2025
Merged
Conversation
kkoehn
force-pushed
the
1680-proforma-export-an-invalid-api-token-is-not-reported-correctly
branch
from
7964ce7 to
1818ac3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1846 +/- ##
==========================================
+ Coverage 94.74% 94.75% +0.01%
==========================================
Files 133 133
Lines 3385 3392 +7
==========================================
+ Hits 3207 3214 +7
Misses 178 178 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This comment was marked as resolved.
This comment was marked as resolved.
kkoehn
force-pushed
the
1680-proforma-export-an-invalid-api-token-is-not-reported-correctly
branch
from
1818ac3 to
c6ee504
Compare
MrSerth
reviewed
Feb 5, 2025
MrSerth
left a comment
MrSerth
left a comment
Member
There was a problem hiding this comment.
Thanks for the further adjustments. I can confirm that only escaped strings are returned. 👏
💁 Please keep in mind: I have not done a regular code review.
kkoehn
force-pushed
the
1680-proforma-export-an-invalid-api-token-is-not-reported-correctly
branch
from
c6ee504 to
4b5dc99
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
kkoehn
force-pushed
the
1680-proforma-export-an-invalid-api-token-is-not-reported-correctly
branch
from
4b5dc99 to
52780c8
Compare
kkoehn
force-pushed
the
1680-proforma-export-an-invalid-api-token-is-not-reported-correctly
branch
from
8f11aa6 to
9f79fc4
Compare
arkirchner
approved these changes
Jul 7, 2025
Co-authored-by: Sebastian Serth <MrSerth@users.noreply.github.com>
kkoehn
force-pushed
the
1680-proforma-export-an-invalid-api-token-is-not-reported-correctly
branch
from
9f79fc4 to
7d59b30
Compare
kkoehn
deleted the
1680-proforma-export-an-invalid-api-token-is-not-reported-correctly
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a more descriptive error message for the presumably most common error.