Skip to content

RfCs: Allow reporting of inappropriate content#2946

Merged
arkirchner merged 4 commits into
mainfrom
ak/2715-report-abuse
Jul 2, 2025
Merged

RfCs: Allow reporting of inappropriate content#2946
arkirchner merged 4 commits into
mainfrom
ak/2715-report-abuse

Conversation

@arkirchner

@arkirchner arkirchner commented Jun 4, 2025

Copy link
Copy Markdown
Contributor

RfCs are user generated content that can be reviewed by other users.
This feature can be misused. A simple email based reporting mechanism
has been added allow users to report this malicious content.

The UI for the RfC comment are part of a separate change.

Relates to #2715

@arkirchner arkirchner self-assigned this Jun 4, 2025
@arkirchner arkirchner force-pushed the ak/2715-report-abuse branch from f17d4bb to 6e416f5 Compare June 4, 2025 16:00
Comment thread docs/LOCAL_SETUP.md Outdated
@arkirchner arkirchner marked this pull request as ready for review June 4, 2025 16:06
@codecov

codecov Bot commented Jun 4, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.76%. Comparing base (7576d1e) to head (c085654).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2946      +/-   ##
==========================================
+ Coverage   69.60%   69.76%   +0.16%     
==========================================
  Files         214      215       +1     
  Lines        6821     6834      +13     
==========================================
+ Hits         4748     4768      +20     
+ Misses       2073     2066       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

MrSerth

This comment was marked as resolved.

@arkirchner arkirchner force-pushed the ak/2715-report-abuse branch 2 times, most recently from f32a3e7 to a46a6d4 Compare June 5, 2025 14:47
Comment thread app/views/report_mailer/report_content.text.erb Outdated
nenock

This comment was marked as resolved.

Comment thread app/controllers/test_sessions_controller.rb Fixed
@MrSerth

MrSerth commented Jun 12, 2025

Copy link
Copy Markdown
Member

Thanks for working on all the comments and improving the code!

Would you please mind improving the git history a little, please? I see some unrelated Dependabot commits in your history that were touched (compared to main). Also, I would appreciate clearer commit messages to various review comments 🙂

Comment thread app/controllers/application_controller.rb Outdated
Comment thread app/controllers/application_controller.rb Outdated
Comment thread app/controllers/request_for_comments_controller.rb Outdated
Comment thread app/controllers/test_sessions_controller.rb Outdated
Comment thread config/locales/de/report.yml
@arkirchner arkirchner force-pushed the ak/2715-report-abuse branch 4 times, most recently from 353dd06 to c3e5d75 Compare June 13, 2025 14:10
Comment thread app/controllers/request_for_comments_controller.rb
Comment thread app/views/request_for_comments/show.html.slim
Comment thread spec/request/request_for_comments_spec.rb Outdated
@arkirchner

This comment was marked as resolved.

MrSerth

This comment was marked as resolved.

Comment thread spec/policies/request_for_comment_policy_spec.rb Outdated
Comment thread spec/policies/request_for_comment_policy_spec.rb Outdated
Comment thread spec/policies/request_for_comment_policy_spec.rb Outdated
Comment thread spec/policies/request_for_comment_policy_spec.rb Outdated
Comment thread spec/policies/request_for_comment_policy_spec.rb Outdated
Comment thread spec/policies/request_for_comment_policy_spec.rb Outdated
Comment thread spec/policies/request_for_comment_policy_spec.rb
Comment thread spec/system/request_for_comments_filter_system_spec.rb Outdated
Comment thread spec/mailers/report_mailer_spec.rb Outdated
Comment thread config/code_ocean.yml.example Outdated
Comment thread app/policies/request_for_comment_policy.rb Outdated
Comment thread spec/views/request_for_comments/report.html.silm_spec.rb Outdated
Comment thread spec/views/request_for_comments/report.html.silm_spec.rb Outdated
Comment thread app/views/report_mailer/report_content.text.slim Outdated
Comment thread config/code_ocean.yml.example Outdated
Comment thread spec/views/request_for_comments/report.html.silm_spec.rb Outdated
Comment thread spec/views/request_for_comments/report.html.silm_spec.rb Outdated
nenock

This comment was marked as resolved.

Comment thread spec/system/request_for_comments_filter_system_spec.rb Outdated
MrSerth

This comment was marked as resolved.

RfCs are user generated content that can be reviewed by other users.
This feature can be misused. A simple email based reporting mechanism
has been added allow users to report this malicious content.

The UI for the RfC comment are part of a separate change.

Relates to #2715
@arkirchner arkirchner force-pushed the ak/2715-report-abuse branch from 4096154 to f985f36 Compare June 30, 2025 09:49
@arkirchner

This comment was marked as resolved.

@MrSerth

This comment was marked as resolved.

@arkirchner

Copy link
Copy Markdown
Contributor Author

Thank you very much for the review. I am sorry that I overlooked the remarks about the view.

I applied the view changes. This moved the button above the question.

1751368329

Comment thread spec/system/report_request_for_comments_system_spec.rb Outdated
@nenock

This comment was marked as resolved.

@MrSerth MrSerth changed the title Allow reporting of malicious content RfCs: Allow reporting of inappropriate content Jul 1, 2025
Co-authored-by: Nele Sina Noack <nele.noack@hpi.de>

@MrSerth MrSerth left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you so much! I can't wait to get your changes live 👏

@arkirchner arkirchner requested a review from nenock July 1, 2025 14:24

@nenock nenock left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't forget to squash the commits 🙏

@arkirchner arkirchner merged commit 75b9297 into main Jul 2, 2025
10 checks passed
@arkirchner arkirchner deleted the ak/2715-report-abuse branch July 2, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants