Skip to content

Specs: Use default study group for internal users#2996

Merged
MrSerth merged 1 commit into
mainfrom
ss/fix_teacher_study_groups
Jul 4, 2025
Merged

Specs: Use default study group for internal users#2996
MrSerth merged 1 commit into
mainfrom
ss/fix_teacher_study_groups

Conversation

@MrSerth

@MrSerth MrSerth commented Jul 2, 2025

Copy link
Copy Markdown
Member

When creating a teacher (or admin) through the respective factory, they were not yet automatically assigned to the respective default study group. This commit changes said behavior.

The actual creation process within the UI remains unchanged, and it is still required to choose the appropriate study groups manually.

Part of #2986

When creating a teacher (or admin) through the respective factory, they were not yet automatically assigned to the respective default study group. This commit changes said behavior.

The actual creation process within the UI remains unchanged, and it is still required to choose the appropriate study groups manually.

Part of #2986
@MrSerth MrSerth self-assigned this Jul 2, 2025
@MrSerth MrSerth added bug ruby Pull requests that update Ruby code labels Jul 2, 2025
@codecov

codecov Bot commented Jul 2, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.07%. Comparing base (75b9297) to head (bfc6487).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2996      +/-   ##
==========================================
+ Coverage   69.76%   70.07%   +0.30%     
==========================================
  Files         215      215              
  Lines        6834     6834              
==========================================
+ Hits         4768     4789      +21     
+ Misses       2066     2045      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MrSerth
MrSerth merged commit a31a4bf into main Jul 4, 2025
10 checks passed
@MrSerth
MrSerth deleted the ss/fix_teacher_study_groups branch July 4, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug ruby Pull requests that update Ruby code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants