Skip to content

Migrate mailers to use parametrized attributes#2999

Merged
MrSerth merged 1 commit into
mainfrom
ss/parameterized_mailers
Jul 4, 2025
Merged

Migrate mailers to use parametrized attributes#2999
MrSerth merged 1 commit into
mainfrom
ss/parameterized_mailers

Conversation

@MrSerth

@MrSerth MrSerth commented Jul 2, 2025

Copy link
Copy Markdown
Member

Related to #2959, we migrate all mailers to use parameterized attributes, since this should work better with testing.

@MrSerth MrSerth self-assigned this Jul 2, 2025
@MrSerth MrSerth added enhancement ruby Pull requests that update Ruby code labels Jul 2, 2025
@codecov

codecov Bot commented Jul 2, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 48.14815% with 14 lines in your changes missing coverage. Please review.

Project coverage is 69.77%. Comparing base (75b9297) to head (350a273).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
app/mailers/user_mailer.rb 59.09% 9 Missing ⚠️
app/controllers/comments_controller.rb 0.00% 2 Missing ⚠️
app/jobs/detect_exercise_anomalies_job.rb 0.00% 2 Missing ⚠️
app/controllers/request_for_comments_controller.rb 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2999   +/-   ##
=======================================
  Coverage   69.76%   69.77%           
=======================================
  Files         215      215           
  Lines        6834     6839    +5     
=======================================
+ Hits         4768     4772    +4     
- Misses       2066     2067    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arkirchner arkirchner left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@MrSerth
MrSerth merged commit 59a96ec into main Jul 4, 2025
9 of 10 checks passed
@MrSerth
MrSerth deleted the ss/parameterized_mailers branch July 4, 2025 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement ruby Pull requests that update Ruby code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants