Skip to content

chore: Enable Rubocop for migrations#3045

Merged
arkirchner merged 1 commit into
mainfrom
ak/rubocop_for_migrations
Jul 30, 2025
Merged

chore: Enable Rubocop for migrations#3045
arkirchner merged 1 commit into
mainfrom
ak/rubocop_for_migrations

Conversation

@arkirchner

Copy link
Copy Markdown
Contributor

Rubocop gives valuable information about issues in migration. New migrations should be checked by the linter.

Rubocop gives valuable information about issues in migration. New
migrations should be checked by the linter.
@arkirchner arkirchner self-assigned this Jul 29, 2025
@codecov

codecov Bot commented Jul 29, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.08%. Comparing base (ea29353) to head (73bb7fa).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3045   +/-   ##
=======================================
  Coverage   70.08%   70.08%           
=======================================
  Files         215      215           
  Lines        6850     6850           
=======================================
  Hits         4801     4801           
  Misses       2049     2049           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arkirchner arkirchner requested a review from kkoehn July 29, 2025 14:36

@kkoehn kkoehn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, I didn't know this existed!

@arkirchner arkirchner merged commit 912fd46 into main Jul 30, 2025
18 of 19 checks passed
@arkirchner arkirchner deleted the ak/rubocop_for_migrations branch July 30, 2025 07:19
@MrSerth

MrSerth commented Jul 30, 2025

Copy link
Copy Markdown
Member

@arkirchner Could you please apply the same changes in CodeHarbor, since the Rubocop configuration is closely set in both projects?

@MrSerth

MrSerth commented Jul 30, 2025

Copy link
Copy Markdown
Member

Thanks for adding similar changes in CodeHarbor with openHPI/codeharbor#2092.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants