Add support for comparing deb packages#68
Conversation
|
Tested with the obs-build changes from https://github.com/bluca/obs-build/commits/build_compare_deb/ on a local OBS VM, seems to work as expected |
fdac174 to
70ff84e
Compare
|
What is the usecase of |
|
One of the packages I was testing this with in my OBS VM, |
|
openconnect package to reproduce it: Without normalizing the elf, a "trigger build" that is otherwise identical ends up being different and being replaced solely due to the revision being in the elf. |
|
As of now, the To me this looks like a deficit in the Debian build system, |
Follow the same pattern as the comparison for rpm packages, and exclude metadata that is expected to change, eg: installed size and version. The same-build-result script detects both rpms and debs and compares whatever it finds. Add some unit tests to cover the new feature.
The build comparison runs in the build root on OBS, so we need native packaging for deb too in order to support comparing them.
|
Ok I've dropped that change now |
|
@olafhering anything else you'd like me to change here? Thanks |
Follow the same pattern as the comparison for rpm packages, and exclude metadata that is expected to change, eg: installed size
and version. The same-build-result script detects both rpms and debs and compares whatever it finds.
Add some unit tests to cover the new feature, and debian packaging, as the comparison runs in the build root on OBS so native packaging is required too.